Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D152629

[libc++][spaceship] P1614R2: Removed ops from `memory_resource`, `polymorphic_allocator`
ClosedPublic
Actions

Authored by H-G-Hristov on Jun 10 2023, 1:33 PM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG6c34aab3ff55: [libc++][spaceship] P1614R2: Removed ops from `memory_resource`…
Summary

Implements parts of P1614R2

  • Removed ops from memory_resource
  • Removed ops from polymorphic_allocator

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 10 2023, 1:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 1:33 PM
Herald added a subscriber: yaxunl. · View Herald Transcript
H-G-Hristov requested review of this revision.Jun 10 2023, 1:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 1:33 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
H-G-Hristov updated this revision to Diff 530246.Jun 10 2023, 1:38 PM

Rebased

H-G-Hristov updated this revision to Diff 530253.Jun 10 2023, 2:28 PM

Rebased

Harbormaster completed remote builds in B237990: Diff 530253.Jun 10 2023, 9:37 PM
Mordante accepted this revision.Jun 11 2023, 5:06 AM
Mordante added a subscriber: Mordante.

LGTM, thanks to the set of operator!= removal patches. I'm really happy this paper is moving to its conclusion!

This revision is now accepted and ready to land.Jun 11 2023, 5:06 AM
H-G-Hristov added a comment.Jun 11 2023, 9:44 AM
In D152629#4411982, @Mordante wrote:

LGTM, thanks to the set of operator!= removal patches. I'm really happy this paper is moving to its conclusion!

Thank you for the review. I'll try to submit more patches daily next week.

Closed by commit rG6c34aab3ff55: [libc++][spaceship] P1614R2: Removed ops from `memory_resource`… (authored by Zingam). · Explain WhyJun 11 2023, 9:49 AM
This revision was automatically updated to reflect the committed changes.
Zingam added a commit: rG6c34aab3ff55: [libc++][spaceship] P1614R2: Removed ops from `memory_resource`….

Revision Contents
Changeset List

PathSize
libcxx/
docs/
Status/
8 lines
include/
__memory_resource/
4 lines
4 lines
4 lines

Diff 530308

View Options

libcxx/docs/Status/SpaceshipProjects.csv

Loading...
View Options

libcxx/include/__memory_resource/memory_resource.h

Loading...
View Options

libcxx/include/__memory_resource/polymorphic_allocator.h

Loading...
View Options

libcxx/include/memory_resource

Loading...