This is an archive of the discontinued LLVM Phabricator instance.

[libc++][spaceship] P1614R2: Added `operator==` to `slice`
ClosedPublic

Authored by H-G-Hristov on Jun 10 2023, 3:59 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGf877e88c354e: [libc++][spaceship] P1614R2: Added `operator==` to `slice`
Summary

Implements parts of P1614R2:

  • Added operator== to slice

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 10 2023, 3:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 3:59 AM
Herald added a subscriber: yaxunl. · View Herald Transcript
H-G-Hristov requested review of this revision.Jun 10 2023, 3:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 3:59 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Added synopsis

Thanks for working on this! I would like to land D152297 first for this one too. But this needs some addition work.

libcxx/include/valarray
408

Note this function should be a hidden friend per http://eel.is/c++draft/hidden.friends.

libcxx/test/std/numerics/numarray/class.slice/slice.ops/slice.ops.pass.cpp
19

Why not use the normal test macros instead?

Try to fix CI

H-G-Hristov planned changes to this revision.Jun 10 2023, 8:01 AM

Addressed comments

Mordante accepted this revision.Jun 11 2023, 5:04 AM

LGTM!

This revision is now accepted and ready to land.Jun 11 2023, 5:04 AM
This revision was automatically updated to reflect the committed changes.