This is an archive of the discontinued LLVM Phabricator instance.

Differential D152615

[libc++][spaceship] P1614R2: Removed ops from `complex`
ClosedPublic

Authored by H-G-Hristov on Jun 10 2023, 2:45 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGbe45fe5d8508: [libc++][spaceship] P1614R2: Removed ops from `complex`
Summary

Implements parts of P1614R2:

  • Removed ops from complex

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 10 2023, 2:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 2:45 AM
Herald added a subscriber: yaxunl. · View Herald Transcript
H-G-Hristov requested review of this revision.Jun 10 2023, 2:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 2:45 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante requested changes to this revision.Jun 10 2023, 6:12 AM
Mordante added a subscriber: Mordante.

In general LGTM, modulo one nit. I would like to land D152297 first and directly update the status page.

libcxx/include/complex
153

We keep all information.

This revision now requires changes to proceed.Jun 10 2023, 6:12 AM
H-G-Hristov added a comment.Jun 10 2023, 6:38 AM

@Mordante Thank you for the review. I'll update the patches and do more of them after we land D152297.

libcxx/include/complex
153

Thank you for letting me know, I haven't seen this before.

Harbormaster completed remote builds in B237942: Diff 530189.Jun 10 2023, 8:56 AM
H-G-Hristov updated this revision to Diff 530239.Jun 10 2023, 12:44 PM

Addressed comments

Harbormaster completed remote builds in B237976: Diff 530239.Jun 10 2023, 3:39 PM
Mordante accepted this revision.Jun 11 2023, 5:02 AM

LGTM!

libcxx/include/complex
153

It's not that common, but we want to know that the difference in our implementation between versions is.

This revision is now accepted and ready to land.Jun 11 2023, 5:02 AM
Closed by commit rGbe45fe5d8508: [libc++][spaceship] P1614R2: Removed ops from `complex` (authored by Zingam). · Explain WhyJun 11 2023, 9:52 AM
This revision was automatically updated to reflect the committed changes.
Zingam added a commit: rGbe45fe5d8508: [libc++][spaceship] P1614R2: Removed ops from `complex`.

Revision Contents

PathSize
libcxx/
include/
16 lines

Diff 530189

libcxx/include/complex

Show First 20 Lines • Show All 142 Lines • ▼ Show 20 Lines
template<class T> complex<T> operator*(const complex<T>&, const complex<T>&); // constexpr in C++20 template<class T> complex<T> operator*(const complex<T>&, const complex<T>&); // constexpr in C++20
template<class T> complex<T> operator*(const complex<T>&, const T&); // constexpr in C++20 template<class T> complex<T> operator*(const complex<T>&, const T&); // constexpr in C++20
template<class T> complex<T> operator*(const T&, const complex<T>&); // constexpr in C++20 template<class T> complex<T> operator*(const T&, const complex<T>&); // constexpr in C++20
template<class T> complex<T> operator/(const complex<T>&, const complex<T>&); // constexpr in C++20 template<class T> complex<T> operator/(const complex<T>&, const complex<T>&); // constexpr in C++20
template<class T> complex<T> operator/(const complex<T>&, const T&); // constexpr in C++20 template<class T> complex<T> operator/(const complex<T>&, const T&); // constexpr in C++20
template<class T> complex<T> operator/(const T&, const complex<T>&); // constexpr in C++20 template<class T> complex<T> operator/(const T&, const complex<T>&); // constexpr in C++20
template<class T> complex<T> operator+(const complex<T>&); // constexpr in C++20 template<class T> complex<T> operator+(const complex<T>&); // constexpr in C++20
template<class T> complex<T> operator-(const complex<T>&); // constexpr in C++20 template<class T> complex<T> operator-(const complex<T>&); // constexpr in C++20
template<class T> bool operator==(const complex<T>&, const complex<T>&); // constexpr in C++14 template<class T> bool operator==(const complex<T>&, const complex<T>&); // constexpr in C++14
template<class T> bool operator==(const complex<T>&, const T&); // constexpr in C++14 template<class T> bool operator==(const complex<T>&, const T&); // constexpr in C++14
template<class T> bool operator==(const T&, const complex<T>&); // constexpr in C++14 template<class T> bool operator==(const T&, const complex<T>&); // removed in C++20
MordanteUnsubmitted
Not Done
ReplyInline Actions
template<class T> bool operator==(const complex<T>&, const T&); // constexpr in C++14
- template<class T> bool operator==(const T&, const complex<T>&); // removed in C++20
+ template<class T> bool operator==(const T&, const complex<T>&); // constexpr in C++14, removed in C++20
template<class T> bool operator!=(const complex<T>&, const complex<T>&); // removed in C++20

We keep all information.

Mordante: We keep all information.
H-G-HristovAuthorUnsubmitted
Done
ReplyInline Actions

Thank you for letting me know, I haven't seen this before.

H-G-Hristov: Thank you for letting me know, I haven't seen this before.
MordanteUnsubmitted
Not Done
ReplyInline Actions

It's not that common, but we want to know that the difference in our implementation between versions is.

Mordante: It's not that common, but we want to know that the difference in our implementation between…
template<class T> bool operator!=(const complex<T>&, const complex<T>&); // constexpr in C++14 template<class T> bool operator!=(const complex<T>&, const complex<T>&); // removed in C++20
template<class T> bool operator!=(const complex<T>&, const T&); // constexpr in C++14 template<class T> bool operator!=(const complex<T>&, const T&); // removed in C++20
template<class T> bool operator!=(const T&, const complex<T>&); // constexpr in C++14 template<class T> bool operator!=(const T&, const complex<T>&); // removed in C++20
template<class T, class charT, class traits> template<class T, class charT, class traits>
basic_istream<charT, traits>& basic_istream<charT, traits>&
operator>>(basic_istream<charT, traits>&, complex<T>&); operator>>(basic_istream<charT, traits>&, complex<T>&);
template<class T, class charT, class traits> template<class T, class charT, class traits>
basic_ostream<charT, traits>& basic_ostream<charT, traits>&
operator<<(basic_ostream<charT, traits>&, const complex<T>&); operator<<(basic_ostream<charT, traits>&, const complex<T>&);
▲ Show 20 Lines • Show All 657 Lines • ▼ Show 20 Lines
template<class _Tp> template<class _Tp>
inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX14 inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX14
bool bool
operator==(const complex<_Tp>& __x, const _Tp& __y) operator==(const complex<_Tp>& __x, const _Tp& __y)
{ {
return __x.real() == __y && __x.imag() == 0; return __x.real() == __y && __x.imag() == 0;
} }
#if _LIBCPP_STD_VER <= 17
template<class _Tp> template<class _Tp>
inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX14 inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX14
bool bool
operator==(const _Tp& __x, const complex<_Tp>& __y) operator==(const _Tp& __x, const complex<_Tp>& __y)
{ {
return __x == __y.real() && 0 == __y.imag(); return __x == __y.real() && 0 == __y.imag();
} }
Show All 16 Lines
template<class _Tp> template<class _Tp>
inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX14 inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX14
bool bool
operator!=(const _Tp& __x, const complex<_Tp>& __y) operator!=(const _Tp& __x, const complex<_Tp>& __y)
{ {
return !(__x == __y); return !(__x == __y);
} }
#endif
// 26.3.7 values: // 26.3.7 values:
template <class _Tp, bool = is_integral<_Tp>::value, template <class _Tp, bool = is_integral<_Tp>::value,
bool = is_floating_point<_Tp>::value bool = is_floating_point<_Tp>::value
> >
struct __libcpp_complex_overload_traits {}; struct __libcpp_complex_overload_traits {};
// Integral Types // Integral Types
▲ Show 20 Lines • Show All 702 Lines • Show Last 20 Lines