Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D152615

[libc++][spaceship] P1614R2: Removed ops from `complex`
ClosedPublic
Actions

Authored by H-G-Hristov on Jun 10 2023, 2:45 AM.

Details

Reviewers

Mordante

Group Reviewers

Restricted Project

Commits

rGbe45fe5d8508: [libc++][spaceship] P1614R2: Removed ops from `complex`

Summary

Implements parts of P1614R2:

Removed ops from complex

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

H-G-Hristov created this revision.Jun 10 2023, 2:45 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 2:45 AM

Herald added a subscriber: yaxunl. · View Herald Transcript

H-G-Hristov requested review of this revision.Jun 10 2023, 2:45 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 2:45 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

In general LGTM, modulo one nit. I would like to land D152297 first and directly update the status page.

libcxx/include/complex
153	We keep all information.

This revision now requires changes to proceed.Jun 10 2023, 6:12 AM

@Mordante Thank you for the review. I'll update the patches and do more of them after we land D152297.

libcxx/include/complex
153	Thank you for letting me know, I haven't seen this before.

Harbormaster completed remote builds in B237942: Diff 530189.Jun 10 2023, 8:56 AM

Addressed comments

Harbormaster completed remote builds in B237976: Diff 530239.Jun 10 2023, 3:39 PM

LGTM!

libcxx/include/complex
153	It's not that common, but we want to know that the difference in our implementation between versions is.

This revision is now accepted and ready to land.Jun 11 2023, 5:02 AM

Closed by commit rGbe45fe5d8508: [libc++][spaceship] P1614R2: Removed ops from `complex` (authored by Zingam). · Explain WhyJun 11 2023, 9:52 AM

This revision was automatically updated to reflect the committed changes.

Zingam added a commit: rGbe45fe5d8508: [libc++][spaceship] P1614R2: Removed ops from `complex`.

Revision Contents
Changeset List

Path

Size

libcxx/

docs/

Status/

SpaceshipProjects.csv

2 lines

include/

complex

16 lines

Diff 530311

View Options

libcxx/docs/Status/SpaceshipProjects.csv