Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D152612

[libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`
ClosedPublic
Actions

Authored by H-G-Hristov on Jun 10 2023, 12:52 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGd1ef99fe1ce3: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`
Summary

Implements parts of P1614R2:

  • Removed global operator!= from allocator

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 10 2023, 12:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 12:52 AM
Herald added a subscriber: yaxunl. · View Herald Transcript
H-G-Hristov requested review of this revision.Jun 10 2023, 12:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 12:52 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
H-G-Hristov retitled this revision from [libc++][spaceship] P1614R2: Removed global `operator!=` for `allocator` to [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`.Jun 10 2023, 2:18 AM
H-G-Hristov edited the summary of this revision. (Show Details)
Mordante requested changes to this revision.Jun 10 2023, 6:07 AM
Mordante added a subscriber: Mordante.

In general LGTM, but I would like to land D152297 first and directly update the status page.

This revision now requires changes to proceed.Jun 10 2023, 6:07 AM
Harbormaster completed remote builds in B237934: Diff 530179.Jun 10 2023, 6:34 AM
H-G-Hristov updated this revision to Diff 530240.Jun 10 2023, 12:51 PM

Addressed comments

H-G-Hristov added a comment.Jun 10 2023, 12:52 PM
In D152612#4411173, @Mordante wrote:

In general LGTM, but I would like to land D152297 first and directly update the status page.

Thank you for the review!

libcxx/include/__memory/allocator.h
268

constexpr since C++20, but removed in C++20. Should I remove the macro?

Harbormaster completed remote builds in B237977: Diff 530240.Jun 10 2023, 4:52 PM
Mordante accepted this revision.Jun 11 2023, 4:58 AM

Thanks, LGTM after applying your own suggestion.

libcxx/include/__memory/allocator.h
268

Good point, yes please do. We're done the same for the relational operator.

This revision is now accepted and ready to land.Jun 11 2023, 4:58 AM
H-G-Hristov updated this revision to Diff 530313.Jun 11 2023, 11:20 AM

Removed macro

Harbormaster completed remote builds in B238038: Diff 530313.Jun 11 2023, 2:11 PM
Closed by commit rGd1ef99fe1ce3: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator` (authored by Zingam). · Explain WhyJun 11 2023, 11:42 PM
This revision was automatically updated to reflect the committed changes.
Zingam added a commit: rGd1ef99fe1ce3: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`.

Revision Contents
Changeset List

PathSize
libcxx/
docs/
Status/
2 lines
include/
__memory/
6 lines
2 lines

Diff 530402

View Options

libcxx/docs/Status/SpaceshipProjects.csv

Loading...
View Options

libcxx/include/__memory/allocator.h

Loading...
View Options

libcxx/include/memory

Loading...