This is an archive of the discontinued LLVM Phabricator instance.

[llvm-lib] Pass the right value of MingwDef to parseCOFFModuleDefinition
ClosedPublic

Authored by mstorsjo on Jun 7 2023, 4:40 AM.

Details

Summary

In llvm-lib cases, the MinGW specific behaviours shouldn't be
enabled.

Not adding any tests to check the corner case behaviours, as this
simply was a mistake when this codepath was added in
395ec4458fb7fc700551f7017c0a395d68c55873 / D144765.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 7 2023, 4:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 4:40 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
mstorsjo requested review of this revision.Jun 7 2023, 4:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 4:40 AM
hans accepted this revision.Jun 7 2023, 5:02 AM

lgtm

This revision is now accepted and ready to land.Jun 7 2023, 5:02 AM