This is an archive of the discontinued LLVM Phabricator instance.

Differential D152359

[COFF] Remove misleading and unclear comments. NFC.
ClosedPublic

Authored by mstorsjo on Jun 7 2023, 4:38 AM.

Details

Reviewers
alvinhochun
mati865
jeremyd2019
Commits
rG9080f619461f: [COFF] Remove misleading and unclear comments. NFC.
Summary

It is not planned that GNU binutils would change this aspect of
its behaviour wrt how symbol decoration is done.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 7 2023, 4:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 4:38 AM
mstorsjo requested review of this revision.Jun 7 2023, 4:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 4:38 AM
Harbormaster completed remote builds in B237231: Diff 529249.Jun 7 2023, 5:01 AM
alvinhochun added a child revision: D152363: [llvm-dlltool] Implement the --no-leading-underscore option.Jun 7 2023, 5:58 AM
mati865 accepted this revision.Jun 7 2023, 7:28 AM

LGTM

This revision is now accepted and ready to land.Jun 7 2023, 7:28 AM
jeremyd2019 accepted this revision.Jun 7 2023, 4:10 PM

LGTM

This revision was landed with ongoing or failed builds.Jun 8 2023, 1:22 PM
Closed by commit rG9080f619461f: [COFF] Remove misleading and unclear comments. NFC. (authored by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG9080f619461f: [COFF] Remove misleading and unclear comments. NFC..
jeremyd2019 mentioned this in D152363: [llvm-dlltool] Implement the --no-leading-underscore option.Jun 8 2023, 9:48 PM

Revision Contents

PathSize
llvm/
include/
llvm/
Object/
3 lines

Diff 529704

llvm/include/llvm/Object/COFFModuleDefinition.h

Show All 33 Linesstruct COFFModuleDefinition {
uint64_t HeapReserve = 0; uint64_t HeapReserve = 0;
uint64_t HeapCommit = 0; uint64_t HeapCommit = 0;
uint32_t MajorImageVersion = 0; uint32_t MajorImageVersion = 0;
uint32_t MinorImageVersion = 0; uint32_t MinorImageVersion = 0;
uint32_t MajorOSVersion = 0; uint32_t MajorOSVersion = 0;
uint32_t MinorOSVersion = 0; uint32_t MinorOSVersion = 0;
}; };
// mingw and wine def files do not mangle _ for x86 which
// is a consequence of legacy binutils' dlltool functionality.
// This MingwDef flag should be removed once mingw stops this pratice.
Expected<COFFModuleDefinition> Expected<COFFModuleDefinition>
parseCOFFModuleDefinition(MemoryBufferRef MB, COFF::MachineTypes Machine, parseCOFFModuleDefinition(MemoryBufferRef MB, COFF::MachineTypes Machine,
bool MingwDef = false); bool MingwDef = false);
} // End namespace object. } // End namespace object.
} // End namespace llvm. } // End namespace llvm.
#endif #endif