[Sanitizers] UUID/Build ID is 16 bytes on Darwin.

[usama54321]

Summary

https://reviews.llvm.org/D114294 changed the kModuleUUIDSize from 16 to 32 for
all platforms. This is not true for Darwin where the UUID is 16 bytes.

rdar://110346025

[usama54321]

Fix typo in test name

[fmayer]

compiler-rt/lib/sanitizer_common/sanitizer_common.h

800

if you have a reference documenting this, could you add this here?

[usama54321]

Changed ifdef to if.

The size of UUID is mostly documented internally. However, I do see references to the size inside the compiler-rt codebase,
such as in the FormatUUID function in sanitizer_mac.cpp.

[thetruestblue]

https://developer.apple.com/documentation/foundation/uuid/1779900-init
RFC 4122 Version 4 is 16 bytes

[usama54321]

Updating missed ifdef to if

compiler-rt/lib/sanitizer_common/sanitizer_common.h

case kModuleArchRISCV64:
       return "riscv64";
     case kModuleArchHexagon:
       return "hexagon";
   }
   CHECK(0 && "Invalid module arch");
   return "";
 }
 
+#if SANITIZER_APPLE
+const uptr kModuleUUIDSize = 16;
+#else
 const uptr kModuleUUIDSize = 32;
+#endif
 const uptr kMaxSegName = 16;
 
 // Represents a binary loaded into virtual memory (e.g. this can be an
 // executable or a shared object).
 class LoadedModule {
  public:
   LoadedModule()
       : full_name_(nullptr),

compiler-rt/lib/sanitizer_common/tests/CMakeLists.txt

set(SANITIZER_UNITTESTS
   sanitizer_hash_test.cpp
   sanitizer_ioctl_test.cpp
   sanitizer_leb128_test.cpp
   sanitizer_libc_test.cpp
   sanitizer_linux_test.cpp
   sanitizer_list_test.cpp
   sanitizer_lzw_test.cpp
   sanitizer_mac_test.cpp
+  sanitizer_module_uuid_size.cpp
   sanitizer_mutex_test.cpp
   sanitizer_nolibc_test.cpp
   sanitizer_posix_test.cpp
   sanitizer_printf_test.cpp
   sanitizer_procmaps_test.cpp
   sanitizer_procmaps_mac_test.cpp
   sanitizer_ring_buffer_test.cpp
   sanitizer_quarantine_test.cpp

compiler-rt/lib/sanitizer_common/tests/sanitizer_module_uuid_size.cpp

+#include "sanitizer_common/sanitizer_common.h"
+#include "gtest/gtest.h"
+
+TEST(ModuleUUID, kModuleUUIDSize) {
+#if SANITIZER_APPLE
+    EXPECT_EQ(__sanitizer::kModuleUUIDSize, 16ULL);
+#else
+    EXPECT_EQ(__sanitizer::kModuleUUIDSize, 32ULL);
+#endif
+}