[lldb] fix dangling reference in `ClangHost.cpp`

[paperchalice]

Summary

The lifetime of clang_resource_path should be same as kResourceDirSuffixes, because kResourceDirSuffixes doesn't own clang_resource_path.

[paperchalice]

If this patch fixes the CI failure, I need someone to commit this change, thanks in advance.

[aprantl]

Thanks!

FWIW, it seems like an unnecessary micro optimization to make both these variables static.

lldb/source/Plugins/ExpressionParser/Clang/ClangHost.cpp

 /// This mode is only used for testing.
 ///
 static bool DefaultComputeClangResourceDirectory(FileSpec &lldb_shlib_spec,
                                                  FileSpec &file_spec,
                                                  bool verify) {
   Log *log = GetLog(LLDBLog::Host);
   std::string raw_path = lldb_shlib_spec.GetPath();
   llvm::StringRef parent_dir = llvm::sys::path::parent_path(raw_path);
-  const std::string clang_resource_path =
+  static const std::string clang_resource_path =
       clang::driver::Driver::GetResourcesPath("bin/lldb", CLANG_RESOURCE_DIR);
 
   static const llvm::StringRef kResourceDirSuffixes[] = {
       // LLVM.org's build of LLDB uses the clang resource directory placed
       // in $install_dir/lib{,64}/clang/$clang_version or
       // $install_dir/bin/$CLANG_RESOURCE_DIR
       clang_resource_path,
       // swift-lldb uses the clang resource directory copied from swift, which