This is an archive of the discontinued LLVM Phabricator instance.

Update clang-repl documentation
ClosedPublic

Authored by Krishna-13-cyber on Jun 4 2023, 10:28 AM.

Details

Summary

Update Clang-repl documentation with:-

  • Add usage and build instructions
  • Add examples depicting their usage in clang-repl.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2023, 10:28 AM
Krishna-13-cyber requested review of this revision.Jun 4 2023, 10:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2023, 10:28 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

I think this is heading in a good direction. Please find some comments inline.

clang/docs/ClangRepl.rst
217
226

I find it surprising to see the build instructions as part of the "usage" section. Can you move it out?

245

A typo?

  • Update with addressing the comments.
QuillPusher accepted this revision.Jun 9 2023, 4:22 PM
This revision is now accepted and ready to land.Jun 9 2023, 4:22 PM
v.g.vassilev added inline comments.Jun 9 2023, 11:58 PM
clang/docs/ClangRepl.rst
119
120
145
146

We can use \ to break lines.

  • Update with addressing the comments
  • Update with example of Dynamic library usage in repl
Krishna-13-cyber marked 2 inline comments as done.
  • Update with addressing the comments
v.g.vassilev accepted this revision.Jun 30 2023, 10:23 AM

LGTM! If you don't have commit access I can commit this on your behalf.

LGTM! If you don't have commit access I can commit this on your behalf.

Yes,
It would be great if you could land it on my behalf!
Thanks.

This revision was landed with ongoing or failed builds.Jul 5 2023, 11:27 AM
This revision was automatically updated to reflect the committed changes.