This is an archive of the discontinued LLVM Phabricator instance.

[libc] Disable the string_to_float test on NVPTX
ClosedPublic

Authored by jhuber6 on Jun 2 2023, 1:56 PM.

Details

Summary

This test began failing after recent changes. Disable it for now.

Diff Detail

Event Timeline

jhuber6 created this revision.Jun 2 2023, 1:56 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 2 2023, 1:56 PM
jhuber6 requested review of this revision.Jun 2 2023, 1:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 2 2023, 1:56 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

The patch is fine, but I am confused as to how the str_to_float tests were passing with the high_precision_decimal tests failing, given that str_to_float uses high_precision_decimal.

The patch is fine, but I am confused as to how the str_to_float tests were passing with the high_precision_decimal tests failing, given that str_to_float uses high_precision_decimal.

I'm not sure either. Haven't had the time to properly diagnose these failings on NVPTX. It's also more difficult for me since it's not my primary development system. I have a feeling there might be a common cause between the spurious failures on NVPTX here but I still to sit down and try to make a reproducer.