This is an archive of the discontinued LLVM Phabricator instance.

[lldb/crashlog] Fix crash when loading non-symbolicated report
ClosedPublic

Authored by mib on May 31 2023, 3:28 PM.

Details

Summary

This patch should address the crashes when parsing a the crash report
frame dictionary.

If the crash report is not symbolicated, the symbolLocation key will
be missing. In that case, we should just use the imageOffset.

rdar://109836386

Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

Diff Detail

Event Timeline

mib created this revision.May 31 2023, 3:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2023, 3:28 PM
mib requested review of this revision.May 31 2023, 3:28 PM
bulbazord added inline comments.May 31 2023, 3:44 PM
lldb/examples/python/crashlog.py
601–604

nit: Why use single quotes for 'symbol' but double quotes for "symbolLocation"? Did some python formatter gives you this?

mib added inline comments.May 31 2023, 3:50 PM
lldb/examples/python/crashlog.py
601–604

yep

bulbazord accepted this revision.May 31 2023, 3:57 PM
This revision is now accepted and ready to land.May 31 2023, 3:57 PM
This revision was automatically updated to reflect the committed changes.