This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add a test for wasm-store-results pass
ClosedPublic

Authored by dschuff on Dec 2 2015, 4:21 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

dschuff updated this revision to Diff 41690.Dec 2 2015, 4:21 PM
dschuff retitled this revision from to [WebAssembly] Add a test for wasm-store-results pass.
dschuff added reviewers: sunfish, jfb.
dschuff added a subscriber: llvm-commits.

Currently there are no tests at all so one test is better than none :), I'm open to suggestions for more.

sunfish accepted this revision.Dec 2 2015, 4:33 PM
sunfish edited edge metadata.

Please add a little one-line comment at the top of the file describing what's being tested.

Otherwise, lgtm. Thanks for catching this.

test/CodeGen/WebAssembly/store-results.ll
13 ↗(On Diff #41690)

The volatile here isn't necessary.

This revision is now accepted and ready to land.Dec 2 2015, 4:33 PM
dschuff updated this revision to Diff 41695.Dec 2 2015, 4:45 PM
dschuff edited edge metadata.
  • Add comment
This revision was automatically updated to reflect the committed changes.