This is an archive of the discontinued LLVM Phabricator instance.

Differential D151381

[lldb][NFCI] Include <cstdio> in SBDefines for FILE * definition
ClosedPublic

Authored by bulbazord on May 24 2023, 3:03 PM.

Details

Reviewers
JDevlieghere
jingham
mib
Commits
rG877ddac051c4: [lldb][NFCI] Include <cstdio> in SBDefines for FILE * definition
Summary

There are a few API headers that use FILE * but do not include the
correct header for their definition. Instead of including <cstdio> in each
of the headers manually, it seems easiest to include it in SBDefines to
get them all at once.

rdar://109579348

Diff Detail

Event Timeline

bulbazord created this revision.May 24 2023, 3:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 3:03 PM
bulbazord requested review of this revision.May 24 2023, 3:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 3:03 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B234335: Diff 525350.May 24 2023, 3:07 PM
bulbazord edited the summary of this revision. (Show Details)May 24 2023, 3:08 PM
JDevlieghere accepted this revision.May 24 2023, 4:24 PM

LGTM

This revision is now accepted and ready to land.May 24 2023, 4:24 PM
mib accepted this revision.May 25 2023, 3:04 PM
Closed by commit rG877ddac051c4: [lldb][NFCI] Include <cstdio> in SBDefines for FILE * definition (authored by bulbazord). · Explain WhyMay 26 2023, 10:56 AM
This revision was automatically updated to reflect the committed changes.
bulbazord added a commit: rG877ddac051c4: [lldb][NFCI] Include <cstdio> in SBDefines for FILE * definition.

Revision Contents

PathSize
lldb/
include/
lldb/
API/
2 lines

Diff 526127

lldb/include/lldb/API/SBDefines.h

Show All 9 Lines
#define LLDB_API_SBDEFINES_H #define LLDB_API_SBDEFINES_H
#include "lldb/lldb-defines.h" #include "lldb/lldb-defines.h"
#include "lldb/lldb-enumerations.h" #include "lldb/lldb-enumerations.h"
#include "lldb/lldb-forward.h" #include "lldb/lldb-forward.h"
#include "lldb/lldb-types.h" #include "lldb/lldb-types.h"
#include "lldb/lldb-versioning.h" #include "lldb/lldb-versioning.h"
#include <cstdio> // For FILE *
#ifndef LLDB_API #ifndef LLDB_API
#if defined(_WIN32) #if defined(_WIN32)
#if defined(LLDB_IN_LIBLLDB) #if defined(LLDB_IN_LIBLLDB)
#define LLDB_API __declspec(dllexport) #define LLDB_API __declspec(dllexport)
#else #else
#define LLDB_API __declspec(dllimport) #define LLDB_API __declspec(dllimport)
#endif #endif
#else // defined (_WIN32) #else // defined (_WIN32)
▲ Show 20 Lines • Show All 103 Lines • Show Last 20 Lines