This is an archive of the discontinued LLVM Phabricator instance.

[lsan] Fix allocator_interface implementation
ClosedPublic

Authored by vitalybuka on May 24 2023, 10:57 AM.

Details

Summary

__sanitizer_get_current_allocated_bytes had as body, but allocator
caches were not registered to collect stats. It's done by
SizeClassAllocator64LocalCache::Init().

Diff Detail

Event Timeline

vitalybuka created this revision.May 24 2023, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 10:57 AM
Herald added a subscriber: Enna1. · View Herald Transcript
vitalybuka requested review of this revision.May 24 2023, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 10:57 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka retitled this revision from [lsan] Fix allocator_interface implementation __sanitizer_get_current_allocated_bytes had as body, but allocator caches were not registered to collect stats. It's done by SizeClassAllocator64LocalCache::Init(). to [lsan] Fix allocator_interface implementation.
vitalybuka edited the summary of this revision. (Show Details)

update

This one is more than XFAIL, we have failed tests in LSAN which query this stats

thurston accepted this revision.May 24 2023, 1:23 PM
This revision is now accepted and ready to land.May 24 2023, 1:23 PM
This revision was landed with ongoing or failed builds.May 24 2023, 1:27 PM
This revision was automatically updated to reflect the committed changes.
dyung added a subscriber: dyung.May 24 2023, 2:44 PM

Hi @vitalybuka, after your change, the test sanitizer_common/TestCases/Linux/release_to_os_test.cpp started to XPASS on a bot https://lab.llvm.org/buildbot/#/builders/247/builds/4903. Can you take a look and if it is expected, remove the XFAIL?