This is an archive of the discontinued LLVM Phabricator instance.

Differential D151248

[libc++][spaceship][NFC] Improved consistency - removed `inline` specifier for `operator<=>`
ClosedPublic

Authored by H-G-Hristov on May 23 2023, 1:05 PM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGcc2d06126653: [libc++][spaceship][NFC] Improved consistency - removed `inline` specifier for…
Summary

Removed inline specifier for consistency as discussed in D148416 previously.

Diff Detail

Event Timeline

H-G-Hristov created this revision.May 23 2023, 1:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 1:05 PM
Herald added a subscriber: yaxunl. · View Herald Transcript
Harbormaster completed remote builds in B233962: Diff 524854.May 23 2023, 10:35 PM
H-G-Hristov published this revision for review.May 24 2023, 7:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 7:08 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante accepted this revision.May 24 2023, 9:43 AM
Mordante added a subscriber: Mordante.

Thanks, LGTM!

This revision is now accepted and ready to land.May 24 2023, 9:43 AM
Closed by commit rGcc2d06126653: [libc++][spaceship][NFC] Improved consistency - removed `inline` specifier for… (authored by Zingam). · Explain WhyMay 25 2023, 12:20 AM
This revision was automatically updated to reflect the committed changes.
Zingam added a commit: rGcc2d06126653: [libc++][spaceship][NFC] Improved consistency - removed `inline` specifier for….

Revision Contents

PathSize
libcxx/
include/
8 lines
9 lines
8 lines
17 lines

Diff 524854

libcxx/include/deque

Show First 20 Lines • Show All 2,596 Lines • ▼ Show 20 Lines
bool bool
operator<=(const deque<_Tp, _Allocator>& __x, const deque<_Tp, _Allocator>& __y) operator<=(const deque<_Tp, _Allocator>& __x, const deque<_Tp, _Allocator>& __y)
{ {
return !(__y < __x); return !(__y < __x);
} }
#else // _LIBCPP_STD_VER <= 17 #else // _LIBCPP_STD_VER <= 17
template<class _Tp, class _Allocator> template <class _Tp, class _Allocator>
inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI __synth_three_way_result<_Tp>
__synth_three_way_result<_Tp> operator<=>(const deque<_Tp, _Allocator>& __x, const deque<_Tp, _Allocator>& __y) {
operator<=>(const deque<_Tp, _Allocator>& __x, const deque<_Tp, _Allocator>& __y)
{
return std::lexicographical_compare_three_way( return std::lexicographical_compare_three_way(
__x.begin(), __x.end(), __y.begin(), __y.end(), std::__synth_three_way<_Tp, _Tp>); __x.begin(), __x.end(), __y.begin(), __y.end(), std::__synth_three_way<_Tp, _Tp>);
} }
#endif // _LIBCPP_STD_VER <= 17 #endif // _LIBCPP_STD_VER <= 17
template <class _Tp, class _Allocator> template <class _Tp, class _Allocator>
inline _LIBCPP_HIDE_FROM_ABI inline _LIBCPP_HIDE_FROM_ABI
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines

libcxx/include/forward_list

Show First 20 Lines • Show All 1,768 Lines • ▼ Show 20 Lines
bool operator<=(const forward_list<_Tp, _Alloc>& __x, bool operator<=(const forward_list<_Tp, _Alloc>& __x,
const forward_list<_Tp, _Alloc>& __y) const forward_list<_Tp, _Alloc>& __y)
{ {
return !(__y < __x); return !(__y < __x);
} }
#else // #if _LIBCPP_STD_VER <= 17 #else // #if _LIBCPP_STD_VER <= 17
template<class _Tp, class _Allocator> template <class _Tp, class _Allocator>
inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI __synth_three_way_result<_Tp>
__synth_three_way_result<_Tp> operator<=>(const forward_list<_Tp, _Allocator>& __x, const forward_list<_Tp, _Allocator>& __y) {
operator<=>(const forward_list<_Tp, _Allocator>& __x,
const forward_list<_Tp, _Allocator>& __y)
{
return std::lexicographical_compare_three_way( return std::lexicographical_compare_three_way(
__x.begin(), __x.end(), __y.begin(), __y.end(), std::__synth_three_way<_Tp, _Tp>); __x.begin(), __x.end(), __y.begin(), __y.end(), std::__synth_three_way<_Tp, _Tp>);
} }
#endif // #if _LIBCPP_STD_VER <= 17 #endif // #if _LIBCPP_STD_VER <= 17
template <class _Tp, class _Alloc> template <class _Tp, class _Alloc>
inline _LIBCPP_INLINE_VISIBILITY inline _LIBCPP_INLINE_VISIBILITY
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines

libcxx/include/list

Show First 20 Lines • Show All 2,339 Lines • ▼ Show 20 Lines
bool bool
operator<=(const list<_Tp, _Alloc>& __x, const list<_Tp, _Alloc>& __y) operator<=(const list<_Tp, _Alloc>& __x, const list<_Tp, _Alloc>& __y)
{ {
return !(__y < __x); return !(__y < __x);
} }
#else // _LIBCPP_STD_VER <= 17 #else // _LIBCPP_STD_VER <= 17
template<class _Tp, class _Allocator> template <class _Tp, class _Allocator>
inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI __synth_three_way_result<_Tp>
__synth_three_way_result<_Tp> operator<=>(const list<_Tp, _Allocator>& __x, const list<_Tp, _Allocator>& __y) {
operator<=>(const list<_Tp, _Allocator>& __x, const list<_Tp, _Allocator>& __y)
{
return std::lexicographical_compare_three_way( return std::lexicographical_compare_three_way(
__x.begin(), __x.end(), __y.begin(), __y.end(), std::__synth_three_way<_Tp, _Tp>); __x.begin(), __x.end(), __y.begin(), __y.end(), std::__synth_three_way<_Tp, _Tp>);
} }
#endif // _LIBCPP_STD_VER <= 17 #endif // _LIBCPP_STD_VER <= 17
template <class _Tp, class _Alloc> template <class _Tp, class _Alloc>
inline _LIBCPP_INLINE_VISIBILITY inline _LIBCPP_INLINE_VISIBILITY
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines

libcxx/include/map

Show First 20 Lines • Show All 1,731 Lines • ▼ Show 20 Lines
operator<=(const map<_Key, _Tp, _Compare, _Allocator>& __x, operator<=(const map<_Key, _Tp, _Compare, _Allocator>& __x,
const map<_Key, _Tp, _Compare, _Allocator>& __y) const map<_Key, _Tp, _Compare, _Allocator>& __y)
{ {
return !(__y < __x); return !(__y < __x);
} }
#else // #if _LIBCPP_STD_VER <= 17 #else // #if _LIBCPP_STD_VER <= 17
template<class _Key, class _Tp, class _Compare, class _Allocator> template <class _Key, class _Tp, class _Compare, class _Allocator>
inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI __synth_three_way_result<pair<const _Key, _Tp>>
__synth_three_way_result<pair<const _Key, _Tp>> operator<=>(const map<_Key, _Tp, _Compare, _Allocator>& __x, const map<_Key, _Tp, _Compare, _Allocator>& __y) {
operator<=>(const map<_Key, _Tp, _Compare, _Allocator>& __x,
const map<_Key, _Tp, _Compare, _Allocator>& __y)
{
return std::lexicographical_compare_three_way( return std::lexicographical_compare_three_way(
__x.begin(), __x.begin(),
__x.end(), __x.end(),
__y.begin(), __y.begin(),
__y.end(), __y.end(),
std::__synth_three_way<pair<const _Key, _Tp>, pair<const _Key, _Tp>>); std::__synth_three_way<pair<const _Key, _Tp>, pair<const _Key, _Tp>>);
} }
▲ Show 20 Lines • Show All 592 Lines • ▼ Show 20 Lines
operator<=(const multimap<_Key, _Tp, _Compare, _Allocator>& __x, operator<=(const multimap<_Key, _Tp, _Compare, _Allocator>& __x,
const multimap<_Key, _Tp, _Compare, _Allocator>& __y) const multimap<_Key, _Tp, _Compare, _Allocator>& __y)
{ {
return !(__y < __x); return !(__y < __x);
} }
#else // #if _LIBCPP_STD_VER <= 17 #else // #if _LIBCPP_STD_VER <= 17
template<class _Key, class _Tp, class _Compare, class _Allocator> template <class _Key, class _Tp, class _Compare, class _Allocator>
inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI __synth_three_way_result<pair<const _Key, _Tp>>
__synth_three_way_result<pair<const _Key, _Tp>>
operator<=>(const multimap<_Key, _Tp, _Compare, _Allocator>& __x, operator<=>(const multimap<_Key, _Tp, _Compare, _Allocator>& __x,
const multimap<_Key, _Tp, _Compare, _Allocator>& __y) const multimap<_Key, _Tp, _Compare, _Allocator>& __y) {
{
return std::lexicographical_compare_three_way( return std::lexicographical_compare_three_way(
__x.begin(), __x.begin(),
__x.end(), __x.end(),
__y.begin(), __y.begin(),
__y.end(), __y.end(),
std::__synth_three_way<pair<const _Key, _Tp>, pair<const _Key, _Tp>>); std::__synth_three_way<pair<const _Key, _Tp>, pair<const _Key, _Tp>>);
} }
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines