This is an archive of the discontinued LLVM Phabricator instance.

Differential D151240

[libc++][PSTL] Make sure that -fexperimental-library enables the PSTL
ClosedPublic

Authored by philnik on May 23 2023, 12:07 PM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rG6bc78f0cdba4: [libc++][PSTL] Make sure that -fexperimental-library enables the PSTL
Summary

@Mordante noticed that this was missing while making <format> non-experimental.

Diff Detail

Unit TestsFailed

TimeTest
40 mslibcxx CI - C++03 > llvm-libc++-shared-cfg-in.libcxx/experimental::fexperimental-library.compile.pass.cpp
30 mslibcxx CI - C++11 > llvm-libc++-shared-cfg-in.libcxx/experimental::fexperimental-library.compile.pass.cpp
30 mslibcxx CI - C++2b > llvm-libc++-shared-cfg-in.libcxx/experimental::fexperimental-library.compile.pass.cpp
5,440 mslibcxx CI - Modular build > llvm-libc++-shared-cfg-in.libcxx/experimental::fexperimental-library.compile.pass.cpp

Event Timeline

philnik created this revision.May 23 2023, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 12:07 PM
philnik requested review of this revision.May 23 2023, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 12:07 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B233948: Diff 524835.May 23 2023, 7:15 PM
ldionne accepted this revision.May 24 2023, 8:09 AM
This revision is now accepted and ready to land.May 24 2023, 8:09 AM
ldionne added inline comments.May 24 2023, 8:10 AM
libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp
30
philnik updated this revision to Diff 525205.May 24 2023, 9:01 AM
philnik marked an inline comment as done.

Try to fix CI

Mordante accepted this revision.May 24 2023, 10:49 AM

LGTM, thanks!

Harbormaster completed remote builds in B234223: Diff 525205.May 24 2023, 3:52 PM
Closed by commit rG6bc78f0cdba4: [libc++][PSTL] Make sure that -fexperimental-library enables the PSTL (authored by philnik). · Explain WhyMay 25 2023, 8:01 AM
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG6bc78f0cdba4: [libc++][PSTL] Make sure that -fexperimental-library enables the PSTL.

Revision Contents

PathSize
libcxx/
test/
libcxx/
experimental/
4 lines

Diff 524835

libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp

Show All 20 Lines
// ADDITIONAL_COMPILE_FLAGS: -fexperimental-library // ADDITIONAL_COMPILE_FLAGS: -fexperimental-library
#include <version> #include <version>
#ifdef _LIBCPP_HAS_NO_INCOMPLETE_FORMAT #ifdef _LIBCPP_HAS_NO_INCOMPLETE_FORMAT
# error "-fexperimental-library should enable <format>" # error "-fexperimental-library should enable <format>"
#endif #endif
#ifndef _LIBCPP_HAS_NO_INCOMPLETE_PSTL
ldionneUnsubmitted
Done
ReplyInline Actions
#endif
- #ifndef _LIBCPP_HAS_NO_INCOMPLETE_PSTL
+ #ifdef _LIBCPP_HAS_NO_INCOMPLETE_PSTL
# error "-fexperimental-library should enable the PSTL"
ldionne:
# error "-fexperimental-library should enable the PSTL"
#endif