This is an archive of the discontinued LLVM Phabricator instance.

[TSan] Remove unused setjmp definitions
ClosedPublic

Authored by melver on May 23 2023, 7:55 AM.

Details

Summary

The __interceptor_*setjmp() definitions appear to have been defined for
the purpose of TSAN_INTERCEPT(), but on non-Mac systems, it seems
TSAN_INTERCEPT() isn't even being used anymore for setjmp.

Remove them. Nothing should call them anyway (due to CHECK-fail), so
having the linker fail is better than failing at runtime.

Diff Detail

Event Timeline

melver created this revision.May 23 2023, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 7:55 AM
melver requested review of this revision.May 23 2023, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 7:55 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
dvyukov accepted this revision.May 23 2023, 7:57 AM
This revision is now accepted and ready to land.May 23 2023, 7:57 AM
This revision was landed with ongoing or failed builds.May 24 2023, 2:58 AM
This revision was automatically updated to reflect the committed changes.