This is an archive of the discontinued LLVM Phabricator instance.

Differential D151143

[LIBC] Add some missing [[noreturn]] attributes
ClosedPublic

Authored by goldstein.w.n on May 22 2023, 12:43 PM.

Details

Reviewers
sivachandra
michaelrj
Commits
rGe0b8f98b1f48: Add some missing [[noreturn]] attributes
Summary

Missing in header for pthread_exit and exit.

Missing in spec file for pthread_exit.

Diff Detail

Event Timeline

goldstein.w.n created this revision.May 22 2023, 12:43 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 22 2023, 12:43 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
goldstein.w.n requested review of this revision.May 22 2023, 12:43 PM
sivachandra accepted this revision.May 22 2023, 12:49 PM

OK if it does not break anything.

This revision is now accepted and ready to land.May 22 2023, 12:49 PM
goldstein.w.n added a comment.May 22 2023, 1:16 PM
In D151143#4362014, @sivachandra wrote:

OK if it does not break anything.

ninja && ninja check-libc && ninja libc-integration-tests
is all green. Missing any tests?

sivachandra added a comment.May 22 2023, 1:21 PM
In D151143#4362116, @goldstein.w.n wrote:
In D151143#4362014, @sivachandra wrote:

OK if it does not break anything.

ninja && ninja check-libc && ninja libc-integration-tests
is all green. Missing any tests?

Good to go.

Harbormaster completed remote builds in B233672: Diff 524439.May 22 2023, 1:22 PM
Closed by commit rGe0b8f98b1f48: Add some missing [[noreturn]] attributes (authored by goldstein.w.n). · Explain WhyMay 22 2023, 1:54 PM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rGe0b8f98b1f48: Add some missing [[noreturn]] attributes.

Revision Contents

PathSize
libc/
spec/
2 lines
src/
pthread/
2 lines
stdlib/
2 lines

Diff 524479

libc/spec/posix.td

Show First 20 Lines • Show All 978 Lines • ▼ Show 20 Lines [
>, >,
FunctionSpec< FunctionSpec<
"pthread_detach", "pthread_detach",
RetValSpec<IntType>, RetValSpec<IntType>,
[ArgSpec<PThreadTType>] [ArgSpec<PThreadTType>]
>, >,
FunctionSpec< FunctionSpec<
"pthread_exit", "pthread_exit",
RetValSpec<VoidType>, RetValSpec<NoReturn>,
[ArgSpec<VoidPtr>] [ArgSpec<VoidPtr>]
>, >,
FunctionSpec< FunctionSpec<
"pthread_self", "pthread_self",
RetValSpec<PThreadTType>, RetValSpec<PThreadTType>,
[ArgSpec<VoidType>] [ArgSpec<VoidType>]
>, >,
FunctionSpec< FunctionSpec<
▲ Show 20 Lines • Show All 423 Lines • Show Last 20 Lines

libc/src/pthread/pthread_exit.h

//===-- Implementation header for pthread_exit function ---------*- C++ -*-===// //===-- Implementation header for pthread_exit function ---------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC_THREADS_PTHREAD_EXIT_H #ifndef LLVM_LIBC_SRC_THREADS_PTHREAD_EXIT_H
#define LLVM_LIBC_SRC_THREADS_PTHREAD_EXIT_H #define LLVM_LIBC_SRC_THREADS_PTHREAD_EXIT_H
#include <pthread.h> #include <pthread.h>
namespace __llvm_libc { namespace __llvm_libc {
void pthread_exit(void *retval); [[noreturn]] void pthread_exit(void *retval);
} // namespace __llvm_libc } // namespace __llvm_libc
#endif // LLVM_LIBC_SRC_THREADS_PTHREAD_EXIT_H #endif // LLVM_LIBC_SRC_THREADS_PTHREAD_EXIT_H

libc/src/stdlib/exit.h

//===-- Implementation header for exit --------------------------*- C++ -*-===// //===-- Implementation header for exit --------------------------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include <stdlib.h> #include <stdlib.h>
#ifndef LLVM_LIBC_SRC_STDLIB_EXIT_H #ifndef LLVM_LIBC_SRC_STDLIB_EXIT_H
#define LLVM_LIBC_SRC_STDLIB_EXIT_H #define LLVM_LIBC_SRC_STDLIB_EXIT_H
namespace __llvm_libc { namespace __llvm_libc {
void exit(int status); [[noreturn]] void exit(int status);
} // namespace __llvm_libc } // namespace __llvm_libc
#endif // LLVM_LIBC_SRC_STDLIB_EXIT_H #endif // LLVM_LIBC_SRC_STDLIB_EXIT_H