This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][MIPS] fix watchpoint searched on client side for same masked variables
ClosedPublic

Authored by mohit.bhakkad on Dec 1 2015, 3:56 AM.

Reviewers

Commits

Summary

rL249837 doesn't solves all the issues with MIPS false positives, some of the cases are not working.
so need to replace it with this logic.

mohit.bhakkad retitled this revision from to [LLDB][MIPS] fix watchpoint searched on client side for same masked variables.

mohit.bhakkad updated this object.

mohit.bhakkad set the repository for this revision to rL LLVM.

clayborg edited edge metadata.

This revision is now accepted and ready to land.Dec 1 2015, 10:00 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

Plugins/

Process/

gdb-remote/

9 lines

Show First 20 Lines • Show All 2,104 Lines • ▼ Show 20 Lines	if (tid != LLDB_INVALID_THREAD_ID)
{		{
StringExtractor desc_extractor(description.c_str());		StringExtractor desc_extractor(description.c_str());
addr_t wp_addr = desc_extractor.GetU64(LLDB_INVALID_ADDRESS);		addr_t wp_addr = desc_extractor.GetU64(LLDB_INVALID_ADDRESS);
uint32_t wp_index = desc_extractor.GetU32(LLDB_INVALID_INDEX32);		uint32_t wp_index = desc_extractor.GetU32(LLDB_INVALID_INDEX32);
addr_t wp_hit_addr = desc_extractor.GetU64(LLDB_INVALID_ADDRESS);		addr_t wp_hit_addr = desc_extractor.GetU64(LLDB_INVALID_ADDRESS);
watch_id_t watch_id = LLDB_INVALID_WATCH_ID;		watch_id_t watch_id = LLDB_INVALID_WATCH_ID;
if (wp_addr != LLDB_INVALID_ADDRESS)		if (wp_addr != LLDB_INVALID_ADDRESS)
{		{
if (wp_hit_addr != LLDB_INVALID_ADDRESS)		WatchpointSP wp_sp;
wp_addr = wp_hit_addr;		ArchSpec::Core core = GetTarget().GetArchitecture().GetCore();
WatchpointSP wp_sp = GetTarget().GetWatchpointList().FindByAddress(wp_addr);		if (core >= ArchSpec::kCore_mips_first && core <= ArchSpec::kCore_mips_last)
		wp_sp = GetTarget().GetWatchpointList().FindByAddress(wp_hit_addr);
		if (!wp_sp)
		wp_sp = GetTarget().GetWatchpointList().FindByAddress(wp_addr);
if (wp_sp)		if (wp_sp)
{		{
wp_sp->SetHardwareIndex(wp_index);		wp_sp->SetHardwareIndex(wp_index);
watch_id = wp_sp->GetID();		watch_id = wp_sp->GetID();
}		}
}		}
if (watch_id == LLDB_INVALID_WATCH_ID)		if (watch_id == LLDB_INVALID_WATCH_ID)
{		{
▲ Show 20 Lines • Show All 3,117 Lines • Show Last 20 Lines