[NFC][CLANG] Fix bug with dereference null return value found by static analyzer tool

[Manna]

Summary

This patch uses castAs instead of getAs which will assert if the type doesn't match in TypeIsInnerPointer(clang::​QualType).

[Manna]

Fix Clang-format error

[Manna]

I have updated patch.

[Manna]

I have updated patch.

[Manna]

This is False Positive. We are correctly matching the type. Closing the PR.

clang/lib/ARCMigrate/ObjCMT.cpp

if (T->isObjCObjectPointerType() || T->isObjCBuiltinType() ||
     return false;
   // Also, typedef-of-pointer-to-incomplete-struct is something that we assume
   // is not an innter pointer type.
   QualType OrigT = T;
   while (const auto *TD = T->getAs<TypedefType>())
     T = TD->getDecl()->getUnderlyingType();
   if (OrigT == T || !T->isPointerType())
     return true;
-  const PointerType* PT = T->getAs<PointerType>();
+  const PointerType *PT = T->castAs<PointerType>();
   QualType UPointeeT = PT->getPointeeType().getUnqualifiedType();
   if (UPointeeT->isRecordType()) {
-    const RecordType *RecordTy = UPointeeT->getAs<RecordType>();
+    const RecordType *RecordTy = UPointeeT->castAs<RecordType>();
     if (!RecordTy->getDecl()->isCompleteDefinition())
       return false;
   }
   return true;
 }
 
 /// Check whether the two versions match.
 static bool versionsMatch(const VersionTuple &X, const VersionTuple &Y) {