[lldb] Fix process pid parsing issue

[mib]

Summary

This patch should fix an issue when parsing the process pid and setting
it in the scripted process.

It can happen that the crashlog.process_id attribute is sometimes
parsed as a string. That would cause the scripted process to pick the
default value (0).

To address that, this patch makes sure that the parsed attributed is
converted to the integer type before passing it to the scripted process.

Signed-off-by: Med Ismail Bennani <[e-mail]>

[bulbazord]

You probably encountered this somewhere, is there a simple test we could add here? The change looks fine to me nonetheless.

[mib]

In D151002#4357886, @bulbazord wrote:

You probably encountered this somewhere, is there a simple test we could add here? The change looks fine to me nonetheless.

This is specific to interactive scripted process and the only test requires Apple Silicon: https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/scripted_crashlog_json.test#L1 so Green Dragon didn't caught this issue.

You should be able to repro by running ninja check-lldb-shell on Apple Silicon.

lldb/examples/python/scripted_process/crashlog_scripted_process.py

 import os,json,struct,signal,uuid
 
 from typing import Any, Dict
 
 import lldb
 from lldb.plugins.scripted_process import ScriptedProcess
 from lldb.plugins.scripted_process import ScriptedThread
 
 from lldb.macosx.crashlog import CrashLog,CrashLogParser
 
 class CrashLogScriptedProcess(ScriptedProcess):
     def set_crashlog(self, crashlog):
         self.crashlog = crashlog
+        if self.crashlog.process_id:
+            if type(self.crashlog.process_id) is int:
                 self.pid = self.crashlog.process_id
+            elif type(self.crashlog.process_id) is str:
+                self.pid = int(self.crashlog.process_id, 0)
+            else:
+                self.pid = super().get_process_id()
         self.addr_mask = self.crashlog.addr_mask
         self.crashed_thread_idx = self.crashlog.crashed_thread_idx
         self.loaded_images = []
         self.exception = self.crashlog.exception
         self.app_specific_thread = None
         if hasattr(self.crashlog, 'asi'):
             self.metadata['asi'] = self.crashlog.asi
         if hasattr(self.crashlog, 'asb'):