This is an archive of the discontinued LLVM Phabricator instance.

Differential D150983

[libc] Fix test failing on the GPU due to undefined floating point type
ClosedPublic

Authored by jhuber6 on May 19 2023, 10:46 AM.

Details

Reviewers
sivachandra
Commits
rG2ac91712cc7b: [libc] Fix test failing on the GPU due to undefined floating point type
Summary

We got build failures due to the handling here, explicitly set the type.

Diff Detail

Event Timeline

jhuber6 created this revision.May 19 2023, 10:46 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 19 2023, 10:46 AM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
jhuber6 requested review of this revision.May 19 2023, 10:46 AM
sivachandra added inline comments.May 19 2023, 12:00 PM
libc/test/src/__support/FPUtil/fpbits_test.cpp
201

The best solution is likely to do this:

#ifdef LONG_DOUBLE_IS_DOUBLE
  return;
#else
  .. // The rest of this test.
#endif

Remove the if constexpr on line 200.

jhuber6 updated this revision to Diff 523885.May 19 2023, 12:01 PM

Changes

sivachandra accepted this revision.May 19 2023, 12:03 PM
This revision is now accepted and ready to land.May 19 2023, 12:03 PM
This revision was landed with ongoing or failed builds.May 19 2023, 12:04 PM
Closed by commit rG2ac91712cc7b: [libc] Fix test failing on the GPU due to undefined floating point type (authored by jhuber6). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhuber6 added a commit: rG2ac91712cc7b: [libc] Fix test failing on the GPU due to undefined floating point type.
Harbormaster completed remote builds in B233264: Diff 523885.May 19 2023, 2:12 PM

Revision Contents

PathSize
libc/
test/
src/
__support/
FPUtil/
7 lines

Diff 523886

libc/test/src/__support/FPUtil/fpbits_test.cpp

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 LinesTEST(LlvmLibcFPBitsTest, X86LongDoubleType) {
EXPECT_EQ(negnum.uintval(), static_cast<UInt128>(0xBFFF9) << 60); EXPECT_EQ(negnum.uintval(), static_cast<UInt128>(0xBFFF9) << 60);
EXPECT_STREQ( EXPECT_STREQ(
negnum.str().c_str(), negnum.str().c_str(),
"0x000000000000BFFF9000000000000000 = " "0x000000000000BFFF9000000000000000 = "
"(S: 1, E: 0x3FFF, I: 1, M: 0x00000000000000001000000000000000)"); "(S: 1, E: 0x3FFF, I: 1, M: 0x00000000000000001000000000000000)");
} }
#else #else
TEST(LlvmLibcFPBitsTest, LongDoubleType) { TEST(LlvmLibcFPBitsTest, LongDoubleType) {
if constexpr (sizeof(long double) == sizeof(double)) #if defined(LONG_DOUBLE_IS_DOUBLE)
return; // The tests for the "double" type cover for this case. return; // The tests for the "double" type cover for this case.
sivachandraUnsubmitted
Not Done
ReplyInline Actions

The best solution is likely to do this:

#ifdef LONG_DOUBLE_IS_DOUBLE
  return;
#else
  .. // The rest of this test.
#endif

Remove the if constexpr on line 200.

sivachandra: The best solution is likely to do this: ``` #ifdef LONG_DOUBLE_IS_DOUBLE return; #else ..
#else
EXPECT_STREQ(FPBits<long double>::inf().str().c_str(), "(+Infinity)"); EXPECT_STREQ(FPBits<long double>::inf().str().c_str(), "(+Infinity)");
EXPECT_STREQ(FPBits<long double>::neg_inf().str().c_str(), "(-Infinity)"); EXPECT_STREQ(FPBits<long double>::neg_inf().str().c_str(), "(-Infinity)");
EXPECT_STREQ( EXPECT_STREQ(
FPBits<long double>(FPBits<long double>::build_nan(1)).str().c_str(), FPBits<long double>(FPBits<long double>::build_nan(1)).str().c_str(),
"(NaN)"); "(NaN)");
FPBits<long double> zero(0.0l); FPBits<long double> zero(0.0l);
EXPECT_EQ(zero.get_sign(), false); EXPECT_EQ(zero.get_sign(), false);
▲ Show 20 Lines • Show All 46 Lines • ▼ Show 20 Lines#else
FPBits<long double> negnum(-1.125l); FPBits<long double> negnum(-1.125l);
EXPECT_EQ(negnum.get_sign(), true); EXPECT_EQ(negnum.get_sign(), true);
EXPECT_EQ(negnum.get_unbiased_exponent(), static_cast<uint16_t>(0x3FFF)); EXPECT_EQ(negnum.get_unbiased_exponent(), static_cast<uint16_t>(0x3FFF));
EXPECT_EQ(negnum.get_mantissa(), static_cast<UInt128>(0x2) << 108); EXPECT_EQ(negnum.get_mantissa(), static_cast<UInt128>(0x2) << 108);
EXPECT_EQ(negnum.uintval(), static_cast<UInt128>(0xBFFF2) << 108); EXPECT_EQ(negnum.uintval(), static_cast<UInt128>(0xBFFF2) << 108);
EXPECT_STREQ(negnum.str().c_str(), EXPECT_STREQ(negnum.str().c_str(),
"0xBFFF2000000000000000000000000000 = " "0xBFFF2000000000000000000000000000 = "
"(S: 1, E: 0x3FFF, M: 0x00002000000000000000000000000000)"); "(S: 1, E: 0x3FFF, M: 0x00002000000000000000000000000000)");
#endif
} }
#endif #endif