[Clang] Enable Clang Sphinx man page build

[aidengrossman]

Summary

This patch makes the current clang-sphinx-docs also build the Clang man
pages. There have been some breakages within this functionality that
haven't been caught for a while (see https://reviews.llvm.org/D149809).
Having coverage of this would probably be a good idea as it shouldn't
cost that much and ensure that this build configuration works.

However, the build was also broken for a fairly significant amount of
time previously and no issues were filed other than the fix I opened, so
maybe this configuration is not particularly important to consumers.

[gkistanova]

LGTM.

buildbot/osuosl/master/config/builders.py

# Builders responsible building Sphinx documentation.
     'workernames' : ["gribozavr3"],
     'builddir': "llvm-sphinx-docs",
     'factory': SphinxDocsBuilder.getSphinxDocsBuildFactory(llvm_html=True, llvm_man=True)},
 
     {'name' : "clang-sphinx-docs",
     'tags'  : ["clang", "doc"],
     'workernames' : ["gribozavr3"],
     'builddir': "clang-sphinx-docs",
-    'factory' : SphinxDocsBuilder.getSphinxDocsBuildFactory(clang_html=True)},
+    'factory' : SphinxDocsBuilder.getSphinxDocsBuildFactory(clang_html=True, clang_man=True)},
 
     {'name' : "clang-tools-sphinx-docs",
     'tags'  : ["clang-tools", "doc"],
     'workernames':["gribozavr3"],
     'builddir':"clang-tools-sphinx-docs",
     'factory': SphinxDocsBuilder.getSphinxDocsBuildFactory(clang_tools_html=True)},
 
     {'name' : "lld-sphinx-docs",

zorg/buildbot/builders/SphinxDocsBuilder.py

llvm_docs = OrderedDict([
   ("polly",             ("docs-polly-html",       "tools/polly/docs/html/",             "polly")),
 ])
 
 
 def getSphinxDocsBuildFactory(
         llvm_html         = False, # Build LLVM HTML documentation
         llvm_man          = False, # Build LLVM man pages
         clang_html        = False, # Build Clang HTML documentation
+        clang_man         = False, # Build Clang man pages
         clang_tools_html  = False, # Build Clang Extra Tools HTML documentation
         lld_html          = False, # Build LLD HTML documentation
         lldb_html         = False, # Build LLDB HTML documentation
         polly_html        = False, # Build Polly HTML documentation
         extra_configure_args = None,
         **kwargs):
 
     if extra_configure_args:
def getSphinxDocsBuildFactory(
     if clang_html:
         f.addStep(NinjaCommand(name="docs-clang-html",
                                haltOnFailure=True,
                                description=["Build Clang Sphinx HTML documentation"],
                                workdir=llvm_objdir,
                                targets=['docs-clang-html']
                               ))
 
+    if clang_man:
+        f.addStep(NinjaCommand(name="docs-clang-man",
+                               haltOnFailure=True,
+                               description=["Build Clang Sphinx man pages"],
+                               workdir=llvm_objdir,
+                               targets=['docs-clang-man']
+                              ))
+
     if clang_tools_html:
         f.addStep(NinjaCommand(name="docs-clang-tools-html",
                                haltOnFailure=True,
                                description=["Build Clang Extra Tools Sphinx HTML documentation"],
                                workdir=llvm_objdir,
                                targets=['docs-clang-tools-html']
                               ))