This is an archive of the discontinued LLVM Phabricator instance.

Differential D150907

[libc++][ci] Install ccache in the Docker image
ClosedPublic

Authored by ldionne on May 18 2023, 2:11 PM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG437ec156ef69: [libc++][ci] Install ccache in the Docker image
Summary

This will allow using ccache in the jobs that build Clang, which
should speed up those jobs.

Diff Detail

Event Timeline

ldionne created this revision.May 18 2023, 2:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2023, 2:11 PM
Herald added a subscriber: arichardson. · View Herald Transcript
ldionne requested review of this revision.May 18 2023, 2:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2023, 2:11 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne added a child revision: D150908: [libc++][ci] Use ccache in the jobs that build Clang.May 18 2023, 2:17 PM
Harbormaster completed remote builds in B233009: Diff 523554.May 18 2023, 10:02 PM
Mordante accepted this revision.May 19 2023, 8:11 AM
Mordante added a subscriber: Mordante.

LGTM! I wonder whether it would make sense to store the cache itself outside the docker image so is can be reused between runs or does the image keep running?

This revision is now accepted and ready to land.May 19 2023, 8:11 AM
ldionne added a comment.May 26 2023, 10:41 AM
In D150907#4356510, @Mordante wrote:

LGTM! I wonder whether it would make sense to store the cache itself outside the docker image so is can be reused between runs or does the image keep running?

My understanding is that the container keeps running between CI jobs, so that shouldn't be needed.

Closed by commit rG437ec156ef69: [libc++][ci] Install ccache in the Docker image (authored by ldionne). · Explain WhyMay 26 2023, 10:42 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG437ec156ef69: [libc++][ci] Install ccache in the Docker image.
Mordante added a comment.May 26 2023, 11:44 AM
In D150907#4376601, @ldionne wrote:
In D150907#4356510, @Mordante wrote:

LGTM! I wonder whether it would make sense to store the cache itself outside the docker image so is can be reused between runs or does the image keep running?

My understanding is that the container keeps running between CI jobs, so that shouldn't be needed.

A great. Some CIs tend to restart containers between runs.

Revision Contents

PathSize
libcxx/
utils/
ci/
4 lines

Diff 526119

libcxx/utils/ci/Dockerfile

Show All 32 Lines
FROM ubuntu:jammy FROM ubuntu:jammy
# Make sure apt-get doesn't try to prompt for stuff like our time zone, etc. # Make sure apt-get doesn't try to prompt for stuff like our time zone, etc.
ENV DEBIAN_FRONTEND=noninteractive ENV DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y bash curl RUN apt-get update && apt-get install -y bash curl
# Install various tools used by the build or the test suite # Install various tools used by the build or the test suite
#RUN apt-get update && apt-get install -y ninja-build python3 python3-sphinx python3-distutils python3-psutil git gdb #RUN apt-get update && apt-get install -y ninja-build python3 python3-sphinx python3-distutils python3-psutil git gdb ccache
# TODO add ninja-build once 1.11 is available in Ubuntu, also remove the manual installation. # TODO add ninja-build once 1.11 is available in Ubuntu, also remove the manual installation.
RUN apt-get update && apt-get install -y python3 python3-sphinx python3-distutils python3-psutil git gdb RUN apt-get update && apt-get install -y python3 python3-sphinx python3-distutils python3-psutil git gdb ccache
RUN apt-get update && apt-get install -y wget && \ RUN apt-get update && apt-get install -y wget && \
wget -qO /usr/local/bin/ninja.gz https://github.com/ninja-build/ninja/releases/latest/download/ninja-linux.zip && \ wget -qO /usr/local/bin/ninja.gz https://github.com/ninja-build/ninja/releases/latest/download/ninja-linux.zip && \
gunzip /usr/local/bin/ninja.gz && \ gunzip /usr/local/bin/ninja.gz && \
chmod a+x /usr/local/bin/ninja chmod a+x /usr/local/bin/ninja
# Install dependencies required to run the LLDB data formatter tests # Install dependencies required to run the LLDB data formatter tests
RUN apt-get update && apt-get install -y python3 python3-dev libpython3-dev uuid-dev libncurses5-dev swig3.0 libxml2-dev libedit-dev RUN apt-get update && apt-get install -y python3 python3-dev libpython3-dev uuid-dev libncurses5-dev swig3.0 libxml2-dev libedit-dev
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines