This is an archive of the discontinued LLVM Phabricator instance.

[libcxxabi] allow downstreams to override _LIBCPP_VERBOSE_ABORT
ClosedPublic

Authored by nickdesaulniers on May 17 2023, 3:50 PM.

Details

Summary

@asbirlea reports that Google does this for sanitizer analysis
downstream. Looks like a few #defines are added into a header which is
then injected into the build.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 3:50 PM
nickdesaulniers requested review of this revision.May 17 2023, 3:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 3:50 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

@vitalybuka does it make more sense to do this or revert cl/507604661?

  • move abort_message.h include into guard
vitalybuka accepted this revision.May 18 2023, 11:32 AM

This is documented feature llvm-project/libcxx/docs/UsingLibcxx.rst and cl/507604661 suppose to used. Before the CL is deprecated.

So this patch is LGTM.

ldionne accepted this revision.May 18 2023, 1:42 PM
This revision is now accepted and ready to land.May 18 2023, 1:42 PM