This is an archive of the discontinued LLVM Phabricator instance.

Differential D15081

Fix the RUN on UBSAN unit tests
ClosedPublic

Authored by sgundapa on Nov 30 2015, 8:10 AM.

Details

Reviewers
rengolin
samsonov
Commits
rGb32a22eab79e: Fix the RUN on UBSAN unit tests
rCRT254467: Fix the RUN on UBSAN unit tests
rL254467: Fix the RUN on UBSAN unit tests
Summary

For the build set up which runs the unit tests using an emulator like QEMU,
the unit tests must be run using %run.

Diff Detail

Event Timeline

sgundapa updated this revision to Diff 41405.Nov 30 2015, 8:10 AM
sgundapa retitled this revision from to Fix the RUN on UBSAN unit tests.
sgundapa updated this object.
sgundapa added reviewers: rengolin, samsonov.
sgundapa added a subscriber: llvm-commits.
samsonov accepted this revision.Nov 30 2015, 10:43 AM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 30 2015, 10:43 AM
Closed by commit rL254467: Fix the RUN on UBSAN unit tests (authored by sgundapa). · Explain WhyDec 1 2015, 3:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
ubsan/
TestCases/
Integer/
2 lines
Misc/
Linux/
2 lines

Diff 41405

test/ubsan/TestCases/Integer/summary.cpp

// RUN: %clangxx -fsanitize=integer %s -o %t // RUN: %clangxx -fsanitize=integer %s -o %t
// RUN: %t 2>&1 | FileCheck %s --check-prefix=CHECK-NOTYPE // RUN: %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-NOTYPE
// RUN: %env_ubsan_opts=report_error_type=1 %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-TYPE // RUN: %env_ubsan_opts=report_error_type=1 %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-TYPE
// REQUIRES: ubsan-asan // REQUIRES: ubsan-asan
#include <stdint.h> #include <stdint.h>
int main() { int main() {
(void)(uint64_t(10000000000000000000ull) + uint64_t(9000000000000000000ull)); (void)(uint64_t(10000000000000000000ull) + uint64_t(9000000000000000000ull));
// CHECK-NOTYPE: SUMMARY: AddressSanitizer: undefined-behavior {{.*}}summary.cpp:[[@LINE-1]]:44 // CHECK-NOTYPE: SUMMARY: AddressSanitizer: undefined-behavior {{.*}}summary.cpp:[[@LINE-1]]:44
// CHECK-TYPE: SUMMARY: AddressSanitizer: unsigned-integer-overflow {{.*}}summary.cpp:[[@LINE-2]]:44 // CHECK-TYPE: SUMMARY: AddressSanitizer: unsigned-integer-overflow {{.*}}summary.cpp:[[@LINE-2]]:44
return 0; return 0;
} }

test/ubsan/TestCases/Misc/Linux/ubsan_options.cc

// RUN: %clangxx -fsanitize=integer -fsanitize-recover=integer %s -o %t // RUN: %clangxx -fsanitize=integer -fsanitize-recover=integer %s -o %t
// RUN: not %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// __ubsan_default_options() doesn't work on Darwin. // __ubsan_default_options() doesn't work on Darwin.
// XFAIL: darwin // XFAIL: darwin
#include <stdint.h> #include <stdint.h>
extern "C" const char *__ubsan_default_options() { extern "C" const char *__ubsan_default_options() {
return "halt_on_error=1"; return "halt_on_error=1";
} }
int main() { int main() {
(void)(uint64_t(10000000000000000000ull) + uint64_t(9000000000000000000ull)); (void)(uint64_t(10000000000000000000ull) + uint64_t(9000000000000000000ull));
// CHECK: ubsan_options.cc:[[@LINE-1]]:44: runtime error: unsigned integer overflow // CHECK: ubsan_options.cc:[[@LINE-1]]:44: runtime error: unsigned integer overflow
return 0; return 0;
} }