[asan] Don't use libstdc++ in test

[abrachet]

Summary

It shouldn't be assumed that libstdc++ is always available even on Linux.
Just let the compiler pick the default

[vitalybuka]

compiler-rt/test/asan/TestCases/throw_invoke_test.cpp

2

Why do we need static-libstdc?

[abrachet]

compiler-rt/test/asan/TestCases/throw_invoke_test.cpp

2

I've just left it because that is what %linux_static_libstdcplusplus used to expand to. Though clearly it should be fine without because non Linux platforms omit this flag. Do you reckon we should remove it entirely?

[vitalybuka]

compiler-rt/test/asan/TestCases/throw_invoke_test.cpp

2

this test runs on windows and osx, so you need some Linux specific substitution
not sure what happen if you remove this completly

[phosek]

compiler-rt/test/lit.common.cfg.py

653

-static-libstdc++ despite the name isn't specific to libstdc++, it applies to whichever -stdlib= is selected. I think it should be sufficient to just drop -stdlib=libstdc++.

[abrachet]

compiler-rt/test/lit.common.cfg.py

653

Right, that is why I have just replaced the use of linux_static_libstdcplusplus with just -static-libstdc++ in the one place it was being used. On the other platforms that wasn't being used, but I doubt that it would make the test wrong on those platforms

[phosek]

LGTM

compiler-rt/test/asan/TestCases/throw_invoke_test.cpp

 // RUN: %clangxx_asan %s -o %t && %run %t
-// RUN: %clangxx_asan %s -o %t %linux_static_libstdcplusplus && %run %t
+// RUN: %clangxx_asan %s -o %t -static-libstdc++ && %run %t
 
 // Investigate why it fails with NDK 21.
 // UNSUPPORTED: android
 
 #include <stdio.h>
 static volatile int zero = 0;
 inline void pretend_to_do_something(void *x) {
   __asm__ __volatile__("" : : "r" (x) : "memory");

compiler-rt/test/lit.common.cfg.py

elif config.host_os == 'SunOS':
     config.substitutions.append( ("%ld_flags_rpath_exe" + postfix, "-Wl,-R\$ORIGIN -L%T -l%xdynamiclib_namespec" + postfix) )
     config.substitutions.append( ("%ld_flags_rpath_so" + postfix, '') )
 
   # Must be defined after the substitutions that use %dynamiclib.
   config.substitutions.append( ("%dynamiclib" + postfix, '%T/%xdynamiclib_filename' + postfix) )
   config.substitutions.append( ("%xdynamiclib_filename" + postfix, 'lib%xdynamiclib_namespec{}.so'.format(postfix)) )
   config.substitutions.append( ("%xdynamiclib_namespec", '%basename_t.dynamic') )
 
-# Provide a substitution that can be used to tell Clang to use a static libstdc++.
-# The substitution expands to nothing on non Linux platforms.
-# FIXME: This should check the target OS, not the host OS.
-if config.host_os == 'Linux':
-  config.substitutions.append( ("%linux_static_libstdcplusplus", "-stdlib=libstdc++ -static-libstdc++") )
-else:
-  config.substitutions.append( ("%linux_static_libstdcplusplus", "") )
-
 config.default_sanitizer_opts = []
 if config.host_os == 'Darwin':
   # On Darwin, we default to `abort_on_error=1`, which would make tests run
   # much slower. Let's override this and run lit tests with 'abort_on_error=0'.
   config.default_sanitizer_opts += ['abort_on_error=0']
   config.default_sanitizer_opts += ['log_to_syslog=0']
   if lit.util.which('log'):
     # Querying the log can only done by a privileged user so