This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho] Remove linking bitcode support
ClosedPublic

Authored by keith on May 16 2023, 11:02 AM.

Details

Reviewers
int3
Group Reviewers
Restricted Project
Commits
rG48e5f704c55f: [lld-macho] Remove linking bitcode support
Summary

Apple deprecated bitcode in the deployment process in Xcode 14.0. Last
month Apple started requiring Xcode 14.1+ to submit apps to the App
Store. Since there isn't a use for bundling bitcode outside of
submitting to the App Store we should be safe to delete this handling
entirely from LLD.

Diff Detail

Event Timeline

keith created this revision.May 16 2023, 11:02 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 16 2023, 11:02 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
keith requested review of this revision.May 16 2023, 11:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2023, 11:02 AM
int3 added a subscriber: int3.May 18 2023, 11:25 AM
int3 added inline comments.
lld/MachO/Driver.cpp
1659

nit: wording seems slightly confusing here, since the bitcode args are still supported in ld64 (just not for App Store uploads). anyway see my suggestion in Options.td

lld/MachO/Options.td
648–661

how about moving all these to grp_obsolete, with a message like "Obsolete since the App Store no longer supports the bitcode build flow"?

We could then drop the custom error message in Driver.cpp for these flags

keith updated this revision to Diff 523517.May 18 2023, 12:50 PM
keith marked 2 inline comments as done.

Move options to obselete instead

keith added a comment.May 30 2023, 9:34 AM

friendly bump

int3 accepted this revision.May 30 2023, 2:28 PM

Sorry, I thought I'd stamped this

This revision is now accepted and ready to land.May 30 2023, 2:28 PM
This revision was automatically updated to reflect the committed changes.
lld/MachO/Writer.cpp