[lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

[jgorbe]

Summary

After https://reviews.llvm.org/D147831, lldb-vscode doesn't send a
process event after launch/attach in case of failure. I believe this is
the right interpretation of the spec, because the description of the
event says:

The event indicates that the debugger has begun debugging a new
process.

and we haven't started debugging a process if there's no process because
we failed to launch it. This is also supported by the fact that
request_launch in vscode.py doesn't wait for the event if passed
expectFailure=True. However, this doesn't take into account
*unexpected* launch failures. In that case, request_launch will hang
indefinitely waiting for the process event.

This patch changes it so we'll only wait for these events if
request["success"] is true, independently of whether any failure was
expected or not.

[jgorbe]

See also https://github.com/llvm/llvm-project/issues/62684

[luporl]

LGTM. With this patch, if I re-enable the restart tests on ARM I get a failure after a few seconds, instead of timing out.

[wallace]

makes sense

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py

def launch(self, program=None, args=None, cwd=None, env=None,
             stopCommands=stopCommands,
             exitCommands=exitCommands,
             terminateCommands=terminateCommands,
             sourcePath=sourcePath,
             debuggerRoot=debuggerRoot,
             launchCommands=launchCommands,
             sourceMap=sourceMap,
             runInTerminal=runInTerminal,
-            expectFailure=expectFailure,
             postRunCommands=postRunCommands)
 
         if expectFailure:
             return response
 
         if not (response and response['success']):
             self.assertTrue(response['success'],
                             'launch failed (%s)' % (response['message']))

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py

class DebugCommunication(object):
 
     def request_launch(self, program, args=None, cwd=None, env=None,
                        stopOnEntry=False, disableASLR=True,
                        disableSTDIO=False, shellExpandArguments=False,
                        trace=False, initCommands=None, preRunCommands=None,
                        stopCommands=None, exitCommands=None,
                        terminateCommands=None ,sourcePath=None,
                        debuggerRoot=None, launchCommands=None, sourceMap=None,
-                       runInTerminal=False, expectFailure=False,
-                       postRunCommands=None):
+                       runInTerminal=False, postRunCommands=None):
         args_dict = {
             'program': program
         }
         if args:
             args_dict['args'] = args
         if cwd:
             args_dict['cwd'] = cwd
         if env:
def request_launch(self, program, args=None, cwd=None, env=None,
             args_dict['postRunCommands'] = postRunCommands
         command_dict = {
             'command': 'launch',
             'type': 'request',
             'arguments': args_dict
         }
         response = self.send_recv(command_dict)
 
-        if not expectFailure:
+        if response['success']:
             # Wait for a 'process' and 'initialized' event in any order
             self.wait_for_event(filter=['process', 'initialized'])
             self.wait_for_event(filter=['process', 'initialized'])
         return response
 
     def request_next(self, threadId):
         if self.exit_status is not None:
             raise ValueError('request_continue called after process exited')