Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D150269

[asan][test][win] Port more tests to not use clang-cl on MinGW (4)
ClosedPublic
Actions

Authored by alvinhochun on May 10 2023, 6:34 AM.

Details

Reviewers
vitalybuka
mstorsjo
Commits
rGfe4a5a08b96a: [asan][test][win] Port more tests to not use clang-cl on MinGW (4)
Summary

This ports some tests that requires dead stripping or ICF.

Diff Detail

Event Timeline

alvinhochun created this revision.May 10 2023, 6:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2023, 6:34 AM
Herald added a subscriber: Enna1. · View Herald Transcript
alvinhochun requested review of this revision.May 10 2023, 6:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2023, 6:34 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B231084: Diff 520973.May 10 2023, 6:35 AM
alvinhochun added a parent revision: D150268: [asan][test][win] Port more tests to not use clang-cl on MinGW (3).May 10 2023, 6:36 AM
alvinhochun added a child revision: D150270: [asan][test][win] Remove `REQUIRES: asan-rtl-heap-interception`.
vitalybuka accepted this revision.May 10 2023, 1:16 PM
vitalybuka added inline comments.
compiler-rt/test/asan/lit.cfg.py
182

if Gw has unique use, maybe just keep in if/else

This revision is now accepted and ready to land.May 10 2023, 1:16 PM
alvinhochun added inline comments.May 12 2023, 1:22 AM
compiler-rt/test/asan/lit.cfg.py
182

It's used in two tests for a total of 4 times, so using substitutions for this does seem a bit cleaner.

alvinhochun mentioned this in D149769: [sanitizer][asan][win][msvc] Correct interception of strdup on windows, additionally correclty intercept memmove/memcpy on i386 windows..May 12 2023, 2:24 AM
This revision was landed with ongoing or failed builds.May 16 2023, 4:54 AM
Closed by commit rGfe4a5a08b96a: [asan][test][win] Port more tests to not use clang-cl on MinGW (4) (authored by alvinhochun). · Explain Why
This revision was automatically updated to reflect the committed changes.
alvinhochun added a commit: rGfe4a5a08b96a: [asan][test][win] Port more tests to not use clang-cl on MinGW (4).

Revision Contents
Changeset List

PathSize
compiler-rt/
test/
asan/
TestCases/
Windows/
10 lines
10 lines
10 lines
8 lines
4 lines

Diff 522549

View Options

compiler-rt/test/asan/TestCases/Windows/dll_global_dead_strip.c

Loading...
View Options

compiler-rt/test/asan/TestCases/Windows/dll_intercept_memcpy.cpp

Loading...
View Options

compiler-rt/test/asan/TestCases/Windows/dll_intercept_memset.cpp

Loading...
View Options

compiler-rt/test/asan/TestCases/Windows/global_dead_strip.c

Loading...
View Options

compiler-rt/test/asan/lit.cfg.py

Loading...