This is an archive of the discontinued LLVM Phabricator instance.

Differential D150063

[clang] Restores some -std=c++2b tests.
ClosedPublic

Authored by Mordante on May 7 2023, 6:01 AM.

Details

Reviewers
aaron.ballman
Commits
rGfd556368a1a8: [clang] Restores some -std=c++2b tests.
Summary

These tests should have added -std=c++23 instead of replacing -std=c++2b
in D149553.

Diff Detail

Event Timeline

Mordante created this revision.May 7 2023, 6:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 6:01 AM
Harbormaster completed remote builds in B230487: Diff 520173.May 7 2023, 7:21 AM
Mordante updated this revision to Diff 520185.May 7 2023, 7:22 AM

Retrigger CI.

Harbormaster completed remote builds in B230495: Diff 520185.May 7 2023, 8:34 AM
Mordante published this revision for review.May 7 2023, 8:39 AM
Mordante edited the summary of this revision. (Show Details)
Mordante removed a parent revision: D150062: [clang][ci] Improves buildkite artifacts..
Mordante added inline comments.
clang/test/Preprocessor/init.c
13

FYI the revision had a parent revision to test some changes for the Clang pre-commit CI not related to this patch at all.

Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 8:40 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.May 8 2023, 4:59 AM

LGTM, good catch!

This revision is now accepted and ready to land.May 8 2023, 4:59 AM
Closed by commit rGfd556368a1a8: [clang] Restores some -std=c++2b tests. (authored by Mordante). · Explain WhyMay 12 2023, 8:45 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGfd556368a1a8: [clang] Restores some -std=c++2b tests..
Mordante mentioned this in D150450: Add C++26 compile flags..May 12 2023, 9:31 AM

Revision Contents

PathSize
clang/
test/
Preprocessor/
2 lines

Diff 521664

clang/test/Preprocessor/init.c

// RUN: %clang_cc1 -E -dM -x assembler-with-cpp < /dev/null | FileCheck -match-full-lines -check-prefix ASM %s // RUN: %clang_cc1 -E -dM -x assembler-with-cpp < /dev/null | FileCheck -match-full-lines -check-prefix ASM %s
// //
// ASM:#define __ASSEMBLER__ 1 // ASM:#define __ASSEMBLER__ 1
// //
// //
// RUN: %clang_cc1 -fblocks -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix BLOCKS %s // RUN: %clang_cc1 -fblocks -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix BLOCKS %s
// //
// BLOCKS:#define __BLOCKS__ 1 // BLOCKS:#define __BLOCKS__ 1
// BLOCKS:#define __block __attribute__((__blocks__(byref))) // BLOCKS:#define __block __attribute__((__blocks__(byref)))
// //
// //
// RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=c++23 -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix CXX2B %s // RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=c++23 -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix CXX2B %s
// RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=c++2b -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix CXX2B %s
MordanteAuthorUnsubmitted
Done
ReplyInline Actions

FYI the revision had a parent revision to test some changes for the Clang pre-commit CI not related to this patch at all.

Mordante: FYI the revision had a parent revision to test some changes for the Clang pre-commit CI not…
// //
// CXX2B:#define __GNUG__ 4 // CXX2B:#define __GNUG__ 4
// CXX2B:#define __GXX_EXPERIMENTAL_CXX0X__ 1 // CXX2B:#define __GXX_EXPERIMENTAL_CXX0X__ 1
// CXX2B:#define __GXX_RTTI 1 // CXX2B:#define __GXX_RTTI 1
// CXX2B:#define __GXX_WEAK__ 1 // CXX2B:#define __GXX_WEAK__ 1
// CXX2B:#define __cplusplus 202101L // CXX2B:#define __cplusplus 202101L
// CXX2B:#define __private_extern__ extern // CXX2B:#define __private_extern__ extern
// //
▲ Show 20 Lines • Show All 108 Lines • ▼ Show 20 Lines
// RUN: %clang_cc1 -E -dM -triple=armv7a-apple-darwin < /dev/null | FileCheck -match-full-lines -check-prefix C-DEFAULT %s // RUN: %clang_cc1 -E -dM -triple=armv7a-apple-darwin < /dev/null | FileCheck -match-full-lines -check-prefix C-DEFAULT %s
// //
// C-DEFAULT:#define __STDC_VERSION__ 201710L // C-DEFAULT:#define __STDC_VERSION__ 201710L
// //
// RUN: %clang_cc1 -ffreestanding -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix FREESTANDING %s // RUN: %clang_cc1 -ffreestanding -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix FREESTANDING %s
// FREESTANDING:#define __STDC_HOSTED__ 0 // FREESTANDING:#define __STDC_HOSTED__ 0
// //
// RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=gnu++23 -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix GXX2B %s // RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=gnu++23 -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix GXX2B %s
// RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=gnu++2b -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix GXX2B %s
// //
// GXX2B:#define __GNUG__ 4 // GXX2B:#define __GNUG__ 4
// GXX2B:#define __GXX_WEAK__ 1 // GXX2B:#define __GXX_WEAK__ 1
// GXX2B:#define __cplusplus 202101L // GXX2B:#define __cplusplus 202101L
// GXX2B:#define __private_extern__ extern // GXX2B:#define __private_extern__ extern
// //
// RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=gnu++20 -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix GXX2A %s // RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=gnu++20 -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix GXX2A %s
// RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=gnu++2a -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix GXX2A %s // RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=gnu++2a -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix GXX2A %s
▲ Show 20 Lines • Show All 2,462 Lines • Show Last 20 Lines