This is an archive of the discontinued LLVM Phabricator instance.

[test] [MCJIT] Don't overwrite config.unsupported to False
ClosedPublic

Authored by mstorsjo on May 5 2023, 2:34 PM.

Details

Summary

An outer directory may have set config.unsupported to True for
a different reason, separate from architecture concerns - we
shouldn't force it back to False just because one criterion is
fulfilled.

This is a preparatory step before a second patch.

Diff Detail

Event Timeline

mstorsjo created this revision.May 5 2023, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 2:34 PM
mstorsjo requested review of this revision.May 5 2023, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 2:34 PM
lhames accepted this revision.May 7 2023, 5:11 PM

LGTM. Thanks @mstorsjo!

This revision is now accepted and ready to land.May 7 2023, 5:11 PM
sgraenitz accepted this revision.Jul 28 2023, 7:02 AM

LGTM too. Is this still up-to-date?

LGTM too. Is this still up-to-date?

I believe so. This was needed for D149996 - which was solved differently and turned out to not be needed in the end. But I guess this cleanup is useful in any case, so I should go ahead and land it.

This revision was landed with ongoing or failed builds.Jul 28 2023, 1:38 PM
This revision was automatically updated to reflect the committed changes.