WIP: Debug symlink creation

[ldionne]

Poke CI

[ldionne]

Check file type

[ldionne]

Make sure we run the Clang pipeline always

[ldionne]

Use tarball

libcxx/utils/ci/buildkite-pipeline-clang.yml

steps:
   - label: "Building clang"
     commands:
       - "mkdir install"
       # We use Release here to avoid including debug information. Otherwise, the clang binary is very large, which
       # is problematic because we need to upload the artifacts for other jobs to use. This may seem like nothing,
       # but with the number of jobs we run daily, this can result in thousands of GB of network I/O.
       - "cmake -S llvm -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install -DLLVM_ENABLE_PROJECTS=\"clang;compiler-rt\""
       - "ninja -C build install-clang install-clang-resource-headers"
-      - "buildkite-agent artifact upload --debug 'install/**/*'"
+      - "tar -czvf install.tar.gz install/"
+      - "buildkite-agent artifact upload --debug install.tar.gz"
     env:
         CC: "clang-${LLVM_HEAD_VERSION}"
         CXX: "clang++-${LLVM_HEAD_VERSION}"
     agents:
       queue: "libcxx-builders"
       os: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
           limit: 2
     timeout_in_minutes: 120
 
   - wait
 
   - label: "C++03"
     commands:
-      - "buildkite-agent artifact download 'install/**' ."
+      - "buildkite-agent artifact download install.tar.gz ."
+      - "tar -xzvf install.tar.gz"
       - "export CC=$(pwd)/install/bin/clang"
       - "export CXX=$(pwd)/install/bin/clang++"
       - "chmod +x install/bin/clang install/bin/clang++"
       - "libcxx/utils/ci/run-buildbot generic-cxx03"
     artifact_paths:
       - "**/test-results.xml"
       - "**/crash_diagnostics/*"
     env:
         LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
         CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
     agents:
       queue: "libcxx-builders"
       os: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
           limit: 2
     timeout_in_minutes: 120
 
   - label: "C++2b"
     commands:
-      - "buildkite-agent artifact download 'install/**' ."
+      - "buildkite-agent artifact download install.tar.gz ."
+      - "tar -xzvf install.tar.gz"
       - "export CC=$(pwd)/install/bin/clang"
       - "export CXX=$(pwd)/install/bin/clang++"
       - "chmod +x install/bin/clang install/bin/clang++"
       - "libcxx/utils/ci/run-buildbot generic-cxx2b"
     artifact_paths:
       - "**/test-results.xml"
       - "**/crash_diagnostics/*"
     env:
         LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
         CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
     agents:
       queue: "libcxx-builders"
       os: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
           limit: 2
     timeout_in_minutes: 120
 
   - label: "Modules"
     commands:
-      - "buildkite-agent artifact download 'install/**' ."
+      - "buildkite-agent artifact download install.tar.gz ."
+      - "tar -xzvf install.tar.gz"
       - "export CC=$(pwd)/install/bin/clang"
       - "export CXX=$(pwd)/install/bin/clang++"
       - "chmod +x install/bin/clang install/bin/clang++"
       - "libcxx/utils/ci/run-buildbot generic-modules"
     artifact_paths:
       - "**/test-results.xml"
       - "**/crash_diagnostics/*"
     env:

libcxx/utils/ci/generate-buildkite-pipeline

 if git diff --name-only HEAD~1 | grep -q -E "^libcxx/|^libcxxabi/|^libunwind/|^runtimes/|^cmake/"; then
   LIBCXX_CHANGED=true
 fi
 
 if git diff --name-only HEAD~1 | grep -q -E "^clang/"; then
   CLANG_CHANGED=true
 fi
 
-if [[ "${CLANG_CHANGED}" == "true" && "${LIBCXX_CHANGED}" != "true" ]]; then
+if [[ "${CLANG_CHANGED}" == "true" ]]; then
   cat libcxx/utils/ci/buildkite-pipeline-clang.yml
 else
   cat libcxx/utils/ci/buildkite-pipeline.yml
 fi

llvm/cmake/modules/LLVMInstallSymlink.cmake

function(install_symlink name target outdir link_or_copy)
   # It should be either "create_symlink" or "copy".
 
   set(DESTDIR $ENV{DESTDIR})
   if(NOT IS_ABSOLUTE "${outdir}")
     set(outdir "${CMAKE_INSTALL_PREFIX}/${outdir}")
   endif()
   set(outdir "${DESTDIR}${outdir}")
 
-  message(STATUS "Creating ${name}")
+  message(STATUS "Creating ${name} with ${link_or_copy}")
 
   execute_process(
     COMMAND "${CMAKE_COMMAND}" -E ${link_or_copy} "${target}" "${name}"
     WORKING_DIRECTORY "${outdir}")
 
 endfunction()