This is an archive of the discontinued LLVM Phabricator instance.

Differential D149737

[clang][ExtractAPI] Add semicolon to function declaration fragments
ClosedPublic

Authored by chaitanyav on May 3 2023, 4:25 AM.

Details

Reviewers
dang
ributzka
Commits
rG14805dcb0d8a: [clang][ExtractAPI] Add semicolon to function declaration fragments
Summary

Add missing semicolon at the end of function declarations to fragments

Diff Detail

Event Timeline

chaitanyav created this revision.May 3 2023, 4:25 AM
Herald added a reviewer: ributzka. · View Herald TranscriptMay 3 2023, 4:25 AM
Herald added a project: Restricted Project. · View Herald Transcript
chaitanyav requested review of this revision.May 3 2023, 4:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2023, 4:25 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
chaitanyav added a comment.May 3 2023, 8:47 AM

@dang @ributzka I missed adding semicolons to function declaration fragments in this commit https://github.com/llvm/llvm-project/commit/afce10c5b60fada1db369d3770f4389da7ef30ef . Please review this.

Harbormaster completed remote builds in B229652: Diff 519028.May 3 2023, 10:47 AM
dang accepted this revision.May 4 2023, 6:44 AM

LGTM

This revision is now accepted and ready to land.May 4 2023, 6:44 AM
Closed by commit rG14805dcb0d8a: [clang][ExtractAPI] Add semicolon to function declaration fragments (authored by chaitanyav). · Explain WhyMay 4 2023, 11:48 AM
This revision was automatically updated to reflect the committed changes.
chaitanyav added a commit: rG14805dcb0d8a: [clang][ExtractAPI] Add semicolon to function declaration fragments.

Revision Contents

PathSize
clang/
lib/
ExtractAPI/
2 lines
test/
ExtractAPI/
10 lines
2 lines
2 lines
4 lines

Diff 519590

clang/lib/ExtractAPI/DeclarationFragments.cpp

Show First 20 Lines • Show All 451 Lines • ▼ Show 20 LinesDeclarationFragmentsBuilder::getFragmentsForFunction(const FunctionDecl *Func) {
for (unsigned i = 0, end = Func->getNumParams(); i != end; ++i) { for (unsigned i = 0, end = Func->getNumParams(); i != end; ++i) {
if (i) if (i)
Fragments.append(", ", DeclarationFragments::FragmentKind::Text); Fragments.append(", ", DeclarationFragments::FragmentKind::Text);
Fragments.append(getFragmentsForParam(Func->getParamDecl(i))); Fragments.append(getFragmentsForParam(Func->getParamDecl(i)));
} }
Fragments.append(")", DeclarationFragments::FragmentKind::Text); Fragments.append(")", DeclarationFragments::FragmentKind::Text);
// FIXME: Handle exception specifiers: throw, noexcept // FIXME: Handle exception specifiers: throw, noexcept
return Fragments; return Fragments.append(";", DeclarationFragments::FragmentKind::Text);
} }
DeclarationFragments DeclarationFragmentsBuilder::getFragmentsForEnumConstant( DeclarationFragments DeclarationFragmentsBuilder::getFragmentsForEnumConstant(
const EnumConstantDecl *EnumConstDecl) { const EnumConstantDecl *EnumConstDecl) {
DeclarationFragments Fragments; DeclarationFragments Fragments;
return Fragments.append(EnumConstDecl->getName(), return Fragments.append(EnumConstDecl->getName(),
DeclarationFragments::FragmentKind::Identifier); DeclarationFragments::FragmentKind::Identifier);
} }
▲ Show 20 Lines • Show All 354 Lines • Show Last 20 Lines

clang/test/ExtractAPI/availability.c

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines "symbols": [
"spelling": " " "spelling": " "
}, },
{ {
"kind": "identifier", "kind": "identifier",
"spelling": "a" "spelling": "a"
}, },
{ {
"kind": "text", "kind": "text",
"spelling": "()" "spelling": "();"
} }
], ],
"functionSignature": { "functionSignature": {
"returns": [ "returns": [
{ {
"kind": "typeIdentifier", "kind": "typeIdentifier",
"preciseIdentifier": "c:v", "preciseIdentifier": "c:v",
"spelling": "void" "spelling": "void"
▲ Show 20 Lines • Show All 57 Lines • ▼ Show 20 Lines "symbols": [
"spelling": " " "spelling": " "
}, },
{ {
"kind": "identifier", "kind": "identifier",
"spelling": "b" "spelling": "b"
}, },
{ {
"kind": "text", "kind": "text",
"spelling": "()" "spelling": "();"
} }
], ],
"functionSignature": { "functionSignature": {
"returns": [ "returns": [
{ {
"kind": "typeIdentifier", "kind": "typeIdentifier",
"preciseIdentifier": "c:v", "preciseIdentifier": "c:v",
"spelling": "void" "spelling": "void"
▲ Show 20 Lines • Show All 67 Lines • ▼ Show 20 Lines "symbols": [
"spelling": " " "spelling": " "
}, },
{ {
"kind": "identifier", "kind": "identifier",
"spelling": "c" "spelling": "c"
}, },
{ {
"kind": "text", "kind": "text",
"spelling": "()" "spelling": "();"
} }
], ],
"functionSignature": { "functionSignature": {
"returns": [ "returns": [
{ {
"kind": "typeIdentifier", "kind": "typeIdentifier",
"preciseIdentifier": "c:v", "preciseIdentifier": "c:v",
"spelling": "void" "spelling": "void"
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 Lines "symbols": [
"spelling": " " "spelling": " "
}, },
{ {
"kind": "identifier", "kind": "identifier",
"spelling": "d" "spelling": "d"
}, },
{ {
"kind": "text", "kind": "text",
"spelling": "()" "spelling": "();"
} }
], ],
"functionSignature": { "functionSignature": {
"returns": [ "returns": [
{ {
"kind": "typeIdentifier", "kind": "typeIdentifier",
"preciseIdentifier": "c:v", "preciseIdentifier": "c:v",
"spelling": "void" "spelling": "void"
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines "symbols": [
"spelling": " " "spelling": " "
}, },
{ {
"kind": "identifier", "kind": "identifier",
"spelling": "e" "spelling": "e"
}, },
{ {
"kind": "text", "kind": "text",
"spelling": "()" "spelling": "();"
} }
], ],
"functionSignature": { "functionSignature": {
"returns": [ "returns": [
{ {
"kind": "typeIdentifier", "kind": "typeIdentifier",
"preciseIdentifier": "c:v", "preciseIdentifier": "c:v",
"spelling": "void" "spelling": "void"
Show All 39 Lines

clang/test/ExtractAPI/global_record.c

Show First 20 Lines • Show All 183 Lines • ▼ Show 20 Lines "symbols": [
"spelling": " * " "spelling": " * "
}, },
{ {
"kind": "internalParam", "kind": "internalParam",
"spelling": "res" "spelling": "res"
}, },
{ {
"kind": "text", "kind": "text",
"spelling": ")" "spelling": ");"
} }
], ],
"docComment": { "docComment": {
"lines": [ "lines": [
{ {
"range": { "range": {
"end": { "end": {
"character": 4, "character": 4,
▲ Show 20 Lines • Show All 193 Lines • Show Last 20 Lines

clang/test/ExtractAPI/global_record_multifile.c

Show First 20 Lines • Show All 185 Lines • ▼ Show 20 Lines "symbols": [
"spelling": " * " "spelling": " * "
}, },
{ {
"kind": "internalParam", "kind": "internalParam",
"spelling": "res" "spelling": "res"
}, },
{ {
"kind": "text", "kind": "text",
"spelling": ")" "spelling": ");"
} }
], ],
"docComment": { "docComment": {
"lines": [ "lines": [
{ {
"range": { "range": {
"end": { "end": {
"character": 4, "character": 4,
▲ Show 20 Lines • Show All 193 Lines • Show Last 20 Lines

clang/test/ExtractAPI/macro_undefined.c

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines "symbols": [
"spelling": " " "spelling": " "
}, },
{ {
"kind": "identifier", "kind": "identifier",
"spelling": "foo" "spelling": "foo"
}, },
{ {
"kind": "text", "kind": "text",
"spelling": "()" "spelling": "();"
} }
], ],
"functionSignature": { "functionSignature": {
"returns": [ "returns": [
{ {
"kind": "typeIdentifier", "kind": "typeIdentifier",
"preciseIdentifier": "c:v", "preciseIdentifier": "c:v",
"spelling": "void" "spelling": "void"
▲ Show 20 Lines • Show All 89 Lines • ▼ Show 20 Lines "symbols": [
"spelling": " " "spelling": " "
}, },
{ {
"kind": "internalParam", "kind": "internalParam",
"spelling": "" "spelling": ""
}, },
{ {
"kind": "text", "kind": "text",
"spelling": ")" "spelling": ");"
} }
], ],
"functionSignature": { "functionSignature": {
"parameters": [ "parameters": [
{ {
"declarationFragments": [ "declarationFragments": [
{ {
"kind": "keyword", "kind": "keyword",
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines