This is an archive of the discontinued LLVM Phabricator instance.

Differential D149730

[libc] Improve the add_libc_test rule.
ClosedPublic

Authored by sivachandra on May 3 2023, 1:03 AM.

Details

Reviewers
jhuber6
Commits
rGfb6faf4798b1: [libc] Improve the add_libc_test rule.
Summary

A target for the test named ${fq_target_name} has been added. It depends
on ${fq_target_name}.unit and ${fq_target_name}.hermetic as
relevant.

Diff Detail

Event Timeline

sivachandra created this revision.May 3 2023, 1:03 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 3 2023, 1:03 AM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
sivachandra requested review of this revision.May 3 2023, 1:03 AM
Harbormaster completed remote builds in B229626: Diff 518996.May 3 2023, 1:10 AM
jhuber6 accepted this revision.May 3 2023, 4:30 AM
This revision is now accepted and ready to land.May 3 2023, 4:30 AM
Closed by commit rGfb6faf4798b1: [libc] Improve the add_libc_test rule. (authored by sivachandra). · Explain WhyMay 4 2023, 11:53 AM
This revision was automatically updated to reflect the committed changes.
sivachandra added a commit: rGfb6faf4798b1: [libc] Improve the add_libc_test rule..
sivachandra added a reverting change: rGb77265711b39: Revert "[libc] Improve the add_libc_test rule.".May 4 2023, 12:11 PM

Revision Contents

PathSize
libc/
cmake/
modules/
8 lines

Diff 519592

libc/cmake/modules/LLVMLibCTestRules.cmake

Show First 20 Lines • Show All 699 Lines • ▼ Show 20 Lines
function(add_libc_test test_name) function(add_libc_test test_name)
cmake_parse_arguments( cmake_parse_arguments(
"LIBC_TEST" "LIBC_TEST"
"UNIT_TEST_ONLY;HERMETIC_TEST_ONLY" # Optional arguments "UNIT_TEST_ONLY;HERMETIC_TEST_ONLY" # Optional arguments
"" # Single value arguments "" # Single value arguments
"" # Multi-value arguments "" # Multi-value arguments
${ARGN} ${ARGN}
) )
get_fq_target_name(${test_name} fq_target_name)
if(LIBC_TEST_UNIT_TEST_ONLY AND LIBC_TEST_HERMETIC_TEST_ONLY)
message(FATAL_ERROR
"${fq_target_name}: Only one of UNIT_TEST_ONLY and HERMETIC_TEST_ONLY can be listed.")
endif()
add_custom_target(${fq_target_name})
if(LIBC_ENABLE_UNITTESTS AND NOT LIBC_TEST_HERMETIC_TEST_ONLY) if(LIBC_ENABLE_UNITTESTS AND NOT LIBC_TEST_HERMETIC_TEST_ONLY)
add_libc_unittest(${test_name}.__unit__ ${LIBC_TEST_UNPARSED_ARGUMENTS}) add_libc_unittest(${test_name}.__unit__ ${LIBC_TEST_UNPARSED_ARGUMENTS})
add_dependencies(${fq_target_name} ${fq_target_name}.__unit__)
endif() endif()
if(LIBC_ENABLE_HERMETIC_TESTS AND NOT LIBC_TEST_UNIT_TEST_ONLY) if(LIBC_ENABLE_HERMETIC_TESTS AND NOT LIBC_TEST_UNIT_TEST_ONLY)
add_libc_hermetic_test(${test_name}.__hermetic__ ${LIBC_TEST_UNPARSED_ARGUMENTS}) add_libc_hermetic_test(${test_name}.__hermetic__ ${LIBC_TEST_UNPARSED_ARGUMENTS})
add_dependencies(${fq_target_name} ${fq_target_name}.__hermetic__)
endif() endif()
endfunction(add_libc_test) endfunction(add_libc_test)