This is an archive of the discontinued LLVM Phabricator instance.

Differential D149420

[KnownBits] Add tests for getting lowbits of `rem X, Y`; NFC
ClosedPublic

Authored by goldstein.w.n on Apr 27 2023, 11:22 PM.

Details

Reviewers
nikic
foad
Commits
rG7b1f123b15da: [KnownBits] Add tests for getting lowbits of `rem X, Y`; NFC

Diff Detail

Unit TestsFailed

TimeTest
5,030 msx64 debian > BOLT.runtime::meta-merge-fdata.test

Event Timeline

goldstein.w.n created this revision.Apr 27 2023, 11:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 11:22 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Apr 27 2023, 11:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 11:22 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D149421: [KnownBits] Improve `KnownBits::rem(X, Y)` in cases where we can deduce low-bits of output.Apr 27 2023, 11:28 PM
Harbormaster completed remote builds in B228740: Diff 517804.Apr 28 2023, 12:30 AM
foad accepted this revision.Apr 28 2023, 3:35 AM
This revision is now accepted and ready to land.Apr 28 2023, 3:35 AM
goldstein.w.n updated this revision to Diff 517953.Apr 28 2023, 9:19 AM

Rebase

Harbormaster completed remote builds in B228850: Diff 517953.Apr 28 2023, 10:10 AM
goldstein.w.n updated this revision to Diff 518018.Apr 28 2023, 12:22 PM

Rebase

Harbormaster completed remote builds in B228898: Diff 518018.Apr 28 2023, 1:09 PM
goldstein.w.n updated this revision to Diff 519239.May 3 2023, 1:56 PM

Rebase

Harbormaster completed remote builds in B229807: Diff 519239.May 3 2023, 2:55 PM
goldstein.w.n updated this revision to Diff 519537.May 4 2023, 9:39 AM

Rebase

Harbormaster completed remote builds in B230014: Diff 519537.May 4 2023, 10:45 AM
goldstein.w.n updated this revision to Diff 519882.May 5 2023, 8:50 AM

Rebase

Harbormaster completed remote builds in B230259: Diff 519882.May 5 2023, 9:23 AM
This revision was landed with ongoing or failed builds.May 7 2023, 5:12 PM
Closed by commit rG7b1f123b15da: [KnownBits] Add tests for getting lowbits of `rem X, Y`; NFC (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG7b1f123b15da: [KnownBits] Add tests for getting lowbits of `rem X, Y`; NFC.

Revision Contents

PathSize
llvm/
test/
Analysis/
ValueTracking/
154 lines

Diff 517804

llvm/test/Analysis/ValueTracking/knownbits-rem-lowbits.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
define i8 @urem_low_bits_know(i8 %xx, i8 %yy) {
; CHECK-LABEL: @urem_low_bits_know(
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 2
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -4
; CHECK-NEXT: [[REM:%.*]] = urem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 2
; CHECK-NEXT: ret i8 [[R]]
;
%x = or i8 %xx, 2
%y = and i8 %yy, -4
%rem = urem i8 %x, %y
%r = and i8 %rem, 2
ret i8 %r
}
define i8 @urem_low_bits_know2(i8 %xx, i8 %yy) {
; CHECK-LABEL: @urem_low_bits_know2(
; CHECK-NEXT: [[XO:%.*]] = and i8 [[XX:%.*]], -4
; CHECK-NEXT: [[X:%.*]] = or i8 [[XO]], 2
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -4
; CHECK-NEXT: [[REM:%.*]] = urem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 3
; CHECK-NEXT: ret i8 [[R]]
;
%xo = or i8 %xx, 2
%x = and i8 %xo, 254
%y = and i8 %yy, -4
%rem = urem i8 %x, %y
%r = and i8 %rem, 3
ret i8 %r
}
define i8 @urem_todo_low_bits_partially_know_should_fold_out_urem(i8 %xx, i8 %yy) {
; CHECK-LABEL: @urem_todo_low_bits_partially_know_should_fold_out_urem(
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 2
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -4
; CHECK-NEXT: [[REM:%.*]] = urem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 3
; CHECK-NEXT: ret i8 [[R]]
;
%x = or i8 %xx, 2
%y = and i8 %yy, -4
%rem = urem i8 %x, %y
%r = and i8 %rem, 3
ret i8 %r
}
define i8 @urem_fail_low_bits_unknown(i8 %xx, i8 %yy) {
; CHECK-LABEL: @urem_fail_low_bits_unknown(
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 4
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -4
; CHECK-NEXT: [[REM:%.*]] = urem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 2
; CHECK-NEXT: ret i8 [[R]]
;
%x = or i8 %xx, 4
%y = and i8 %yy, -4
%rem = urem i8 %x, %y
%r = and i8 %rem, 2
ret i8 %r
}
define i8 @urem_fail_low_bits_unknown2(i8 %xx, i8 %yy) {
; CHECK-LABEL: @urem_fail_low_bits_unknown2(
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 1
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -5
; CHECK-NEXT: [[REM:%.*]] = urem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 2
; CHECK-NEXT: ret i8 [[R]]
;
%x = or i8 %xx, 1
%y = and i8 %yy, -5
%rem = urem i8 %x, %y
%r = and i8 %rem, 2
ret i8 %r
}
define i8 @srem_low_bits_know(i8 %xx, i8 %yy) {
; CHECK-LABEL: @srem_low_bits_know(
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 10
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -4
; CHECK-NEXT: [[REM:%.*]] = srem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 2
; CHECK-NEXT: ret i8 [[R]]
;
%x = or i8 %xx, 10
%y = and i8 %yy, -4
%rem = srem i8 %x, %y
%r = and i8 %rem, 2
ret i8 %r
}
define i8 @srem_low_bits_know2(i8 %xx, i8 %yy) {
; CHECK-LABEL: @srem_low_bits_know2(
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 1
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -2
; CHECK-NEXT: [[REM:%.*]] = srem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 1
; CHECK-NEXT: ret i8 [[R]]
;
%x = or i8 %xx, 1
%y = and i8 %yy, -2
%rem = srem i8 %x, %y
%r = and i8 %rem, 1
ret i8 %r
}
define i8 @srem_todo_low_bits_partially_know_should_fold_out_srem(i8 %xx, i8 %yy) {
; CHECK-LABEL: @srem_todo_low_bits_partially_know_should_fold_out_srem(
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 10
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -4
; CHECK-NEXT: [[REM:%.*]] = srem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 3
; CHECK-NEXT: ret i8 [[R]]
;
%x = or i8 %xx, 10
%y = and i8 %yy, -4
%rem = srem i8 %x, %y
%r = and i8 %rem, 3
ret i8 %r
}
define i8 @srem_fail_low_bits_unknown(i8 %xx, i8 %yy) {
; CHECK-LABEL: @srem_fail_low_bits_unknown(
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 4
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -4
; CHECK-NEXT: [[REM:%.*]] = srem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 2
; CHECK-NEXT: ret i8 [[R]]
;
%x = or i8 %xx, 4
%y = and i8 %yy, -4
%rem = srem i8 %x, %y
%r = and i8 %rem, 2
ret i8 %r
}
define i8 @srem_fail_irrelivent_bits_known(i8 %xx, i8 %yy) {
; CHECK-LABEL: @srem_fail_irrelivent_bits_known(
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 3
; CHECK-NEXT: [[Y:%.*]] = and i8 [[YY:%.*]], -6
; CHECK-NEXT: [[REM:%.*]] = srem i8 [[X]], [[Y]]
; CHECK-NEXT: [[R:%.*]] = and i8 [[REM]], 2
; CHECK-NEXT: ret i8 [[R]]
;
%x = or i8 %xx, 3
%y = and i8 %yy, -6
%rem = srem i8 %x, %y
%r = and i8 %rem, 2
ret i8 %r
}