This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][ASan] Fix description of __sanitizer_annotate_contiguous_container
ClosedPublic

Authored by AdvenamTacet on Apr 27 2023, 6:08 AM.

Details

Summary

This revision updates the description of
__sanitizer_annotate_contiguous_container in includes. Possibilites of
the function were changed in D132522 and it supports:

  • unaligned beginning,
  • shared first/last granule with other objects.

Diff Detail

Event Timeline

AdvenamTacet created this revision.Apr 27 2023, 6:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 6:08 AM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
AdvenamTacet requested review of this revision.Apr 27 2023, 6:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 6:08 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Maybe it's a good idea to cherry-pick this commit into LLVM 16? That only updates a comment and new description is true since rGdd1b7b797a116eed588fd752fbe61d34deeb24e4.

vitalybuka accepted this revision.Apr 27 2023, 2:34 PM

Maybe it's a good idea to cherry-pick this commit into LLVM 16? That only updates a comment and new description is true since rGdd1b7b797a116eed588fd752fbe61d34deeb24e4.

Maybe comment that unaligned beg/end may result in false negatives in those granules. No need to add detailed explanation why.

This revision is now accepted and ready to land.Apr 27 2023, 2:34 PM

This update adds a note that unalinged beginning and end may result in false negatives.

PS
I do not have a commiter rights.

vitalybuka edited the summary of this revision. (Show Details)Apr 30 2023, 10:20 PM