This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Unbreak passing multiple env variables in ssh.py
ClosedPublic

Authored by mstorsjo on Apr 27 2023, 12:15 AM.

Details

Summary

No test actually does this, but this makes the option behave like
the corresponding one in run.py.

This was broken by commit b8b23aa80eefe84187d6ba364d06496c90c53bdb
(https://reviews.llvm.org/D99242) which introduced quoting; instead
of quoting the whole space separated list, quote each individual
argument.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 27 2023, 12:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 12:15 AM
Herald added a subscriber: arichardson. · View Herald Transcript
mstorsjo requested review of this revision.Apr 27 2023, 12:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 12:15 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Apr 27 2023, 8:08 AM
This revision is now accepted and ready to land.Apr 27 2023, 8:08 AM
This revision was landed with ongoing or failed builds.Apr 27 2023, 9:27 AM
This revision was automatically updated to reflect the committed changes.