This is an archive of the discontinued LLVM Phabricator instance.

Differential D149284

[lldb] Remove finding .Bundle directories in PlatformDarwinKernel
ClosedPublic

Authored by bulbazord on Apr 26 2023, 12:48 PM.

Details

Reviewers
jasonmolenda
Commits
rG33d6bd1c6674: [lldb] Remove finding .Bundle directories in PlatformDarwinKernel
Summary

Jason isn't sure what this is used for and isn't aware of a .Bundle
suffix related to kernel debugging. Let's remove it.

Diff Detail

Event Timeline

bulbazord created this revision.Apr 26 2023, 12:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 12:48 PM
bulbazord requested review of this revision.Apr 26 2023, 12:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 12:48 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B228364: Diff 517272.Apr 26 2023, 12:52 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptApr 26 2023, 12:52 PM
jasonmolenda added a comment.Apr 26 2023, 12:55 PM

I added this in 2016 via 243bd763ecad466fac748b565ea52c661107684d and I have no idea what it is for. I know of no such prefix related to kernel debugging. Let's remove it instead.

bulbazord added a comment.Apr 26 2023, 12:56 PM
In D149284#4299933, @jasonmolenda wrote:

I added this in 2016 via 243bd763ecad466fac748b565ea52c661107684d and I have no idea what it is for. I know of no such prefix related to kernel debugging. Let's remove it instead.

Sounds good, will update this.

bulbazord updated this revision to Diff 517309.Apr 26 2023, 2:02 PM

Remove code instead of attempting to fix things

bulbazord retitled this revision from [lldb] Fix finding .Bundle directories in PlatformDarwinKernel to [lldb] Remove finding .Bundle directories in PlatformDarwinKernel.Apr 26 2023, 2:02 PM
bulbazord edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B228391: Diff 517309.Apr 26 2023, 2:05 PM
jasonmolenda accepted this revision.Apr 26 2023, 2:39 PM

Thank you for cleaning this one up.

This revision is now accepted and ready to land.Apr 26 2023, 2:39 PM
Closed by commit rG33d6bd1c6674: [lldb] Remove finding .Bundle directories in PlatformDarwinKernel (authored by bulbazord). · Explain WhyApr 26 2023, 2:54 PM
This revision was automatically updated to reflect the committed changes.
bulbazord added a commit: rG33d6bd1c6674: [lldb] Remove finding .Bundle directories in PlatformDarwinKernel.

Revision Contents

PathSize
lldb/
source/
Plugins/
Platform/
MacOSX/
2 lines

Diff 517272

lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp

Show First 20 Lines • Show All 476 Lines • ▼ Show 20 Lines
} }
FileSystem::EnumerateDirectoryResult FileSystem::EnumerateDirectoryResult
PlatformDarwinKernel::GetKernelsAndKextsInDirectoryHelper( PlatformDarwinKernel::GetKernelsAndKextsInDirectoryHelper(
void *baton, llvm::sys::fs::file_type ft, llvm::StringRef path, void *baton, llvm::sys::fs::file_type ft, llvm::StringRef path,
bool recurse) { bool recurse) {
static ConstString g_kext_suffix = ConstString(".kext"); static ConstString g_kext_suffix = ConstString(".kext");
static ConstString g_dsym_suffix = ConstString(".dSYM"); static ConstString g_dsym_suffix = ConstString(".dSYM");
static ConstString g_bundle_suffix = ConstString("Bundle"); static ConstString g_bundle_suffix = ConstString(".Bundle");
FileSpec file_spec(path); FileSpec file_spec(path);
ConstString file_spec_extension = file_spec.GetFileNameExtension(); ConstString file_spec_extension = file_spec.GetFileNameExtension();
Log *log = GetLog(LLDBLog::Platform); Log *log = GetLog(LLDBLog::Platform);
LLDB_LOGV(log, "PlatformDarwinKernel examining '{0}'", file_spec); LLDB_LOGV(log, "PlatformDarwinKernel examining '{0}'", file_spec);
▲ Show 20 Lines • Show All 518 Lines • Show Last 20 Lines