This is an archive of the discontinued LLVM Phabricator instance.

Differential D149255

[libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test
ClosedPublic

Authored by Jake-Egan on Apr 26 2023, 6:27 AM.

Details

Reviewers
daltenty
sfertile
Mordante
Group Reviewers
Restricted Project
Commits
rGefd0b42171e9: [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test
Summary

This test was originally unsupported for LIBCXX-AIX-FIXME feature because we lacked -fvisibility=hidden support. AIX now has visibility support and the test passes in debug mode.

Diff Detail

Event Timeline

Jake-Egan created this revision.Apr 26 2023, 6:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 6:27 AM
Jake-Egan requested review of this revision.Apr 26 2023, 6:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 6:27 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Jake-Egan edited the summary of this revision. (Show Details)Apr 26 2023, 6:28 AM
Jake-Egan added reviewers: daltenty, sfertile.
Jake-Egan planned changes to this revision.Apr 26 2023, 7:27 AM
Harbormaster completed remote builds in B228277: Diff 517144.Apr 26 2023, 7:54 AM
Jake-Egan requested review of this revision.May 1 2023, 6:40 AM
Jake-Egan edited the summary of this revision. (Show Details)
Mordante accepted this revision.May 7 2023, 8:48 AM
Mordante added a subscriber: Mordante.

LGTM! The CI failures are unrelated to this patch.

This revision is now accepted and ready to land.May 7 2023, 8:48 AM
This revision was landed with ongoing or failed builds.May 8 2023, 7:54 AM
Closed by commit rGefd0b42171e9: [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test (authored by Jake-Egan). · Explain Why
This revision was automatically updated to reflect the committed changes.
Jake-Egan added a commit: rGefd0b42171e9: [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test.

Revision Contents

PathSize
libcxx/
test/
libcxx/
debug/
2 lines

Diff 520377

libcxx/test/libcxx/debug/extern-templates.sh.cpp

Show All 15 Lines
// This test relies on linking a shared library and then passing that shared // This test relies on linking a shared library and then passing that shared
// library as input when linking an executable; this is generally not supported // library as input when linking an executable; this is generally not supported
// on Windows (GNU ld supports it, but MS link.exe and LLD don't) - one has to // on Windows (GNU ld supports it, but MS link.exe and LLD don't) - one has to
// use an import library instead. (Additionally, the test uses the -fPIC // use an import library instead. (Additionally, the test uses the -fPIC
// option which clang doesn't accept on Windows.) // option which clang doesn't accept on Windows.)
// UNSUPPORTED: windows // UNSUPPORTED: windows
// XFAIL: LIBCXX-AIX-FIXME
// RUN: %{cxx} %{flags} %{compile_flags} %s %{link_flags} -fPIC -DTU1 -fvisibility=hidden -shared -o %t.lib // RUN: %{cxx} %{flags} %{compile_flags} %s %{link_flags} -fPIC -DTU1 -fvisibility=hidden -shared -o %t.lib
// RUN: cd %T && %{cxx} %{flags} %{compile_flags} %s ./%basename_t.tmp.lib %{link_flags} -DTU2 -fvisibility=hidden -o %t.exe // RUN: cd %T && %{cxx} %{flags} %{compile_flags} %s ./%basename_t.tmp.lib %{link_flags} -DTU2 -fvisibility=hidden -o %t.exe
// RUN: %{exec} %t.exe // RUN: %{exec} %t.exe
#include <cassert> #include <cassert>
#include <cstdio> #include <cstdio>
#include <sstream> #include <sstream>
#include <string> #include <string>
Show All 21 Lines