This is an archive of the discontinued LLVM Phabricator instance.

[Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h
ClosedPublic

Authored by probinson on Apr 25 2023, 2:31 PM.

Diff Detail

Event Timeline

probinson created this revision.Apr 25 2023, 2:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 2:31 PM
probinson requested review of this revision.Apr 25 2023, 2:31 PM
goldstein.w.n accepted this revision.Apr 25 2023, 4:28 PM

LGTM. I'm not a maintainer so wait a day to push so others can take a look.

clang/lib/Headers/avx2intrin.h
789

Remove extrenous change?

This revision is now accepted and ready to land.Apr 25 2023, 4:28 PM
pengfei accepted this revision.Apr 25 2023, 8:45 PM

LGTM with one nit.

clang/lib/Headers/avx2intrin.h
943

Use \code{.operation} please, the same below. Our internal tool will recognize this pattern.

probinson marked 2 inline comments as done.Apr 26 2023, 8:04 AM
probinson added inline comments.
clang/lib/Headers/avx2intrin.h
943

Ok. I'll modify our tooling to ignore it.

This revision was landed with ongoing or failed builds.Apr 26 2023, 8:04 AM
This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 8:04 AM