This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][REPL] Destroy the repl instances correctly
ClosedPublic

Authored by wallace on Apr 25 2023, 1:01 PM.

Details

Summary

This change ensures that the REPL map inside Target is destroyed correctly when Target::Destroy() is invoked. Not doing so results in the REPL not finishing its job when the debugger is initialized in REPL mode reading from a file. In my particular case, my REPL doesn't print the stdout of the last expression in the input file unless I include this change.

Diff Detail

Event Timeline

wallace created this revision.Apr 25 2023, 1:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 1:01 PM
wallace requested review of this revision.Apr 25 2023, 1:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 1:01 PM
rriddle accepted this revision.Apr 25 2023, 1:05 PM
This revision is now accepted and ready to land.Apr 25 2023, 1:05 PM
This revision was landed with ongoing or failed builds.Apr 25 2023, 1:09 PM
This revision was automatically updated to reflect the committed changes.