[CodeGen] fix ungated debug call

[Ezrashaw]

Summary

put some debug calls in a LLVM_DEBUG invocation

[Ezrashaw]

Sorry, I might've mucked up setting a reviewer?

Obviously I'm a first-time contributor. Some context: I'm a rustc developer and this debug info came up in https://github.com/rust-lang/rust/issues/110743.

[Ezrashaw]

Thanks @kazu. Obviously I'm a first-time contributor so it'd be great if you could land the change :)

[Ezrashaw]

@kazu It's been about a week. Please could you commit this change with “Ezra Shaw [e-mail]”. If I'm doing something wrong, it'd be great to know :P

[kazu]

Sorry for dropping the ball on this. It looks like the following commit has fixed the problem:

https://github.com/llvm/llvm-project/commit/bcaa0b26aa7c39fc1403e1bb9c2c74f9e7ba704b

[Ezrashaw]

That's all fine. Not sure how I should close this now?

[kazu]

In D149129#4378214, @Ezrashaw wrote:

That's all fine. Not sure how I should close this now?

I think you as the original author can abandon this patch. Scroll all the way down to the bottom and look for "Add Action". You should be able to select "Abandon" there.

llvm/lib/CodeGen/PrologEpilogInserter.cpp

for (int Idx = MFI.getObjectIndexBegin(), End = MFI.getObjectIndexEnd();
       if (MFI.isSpillSlotObjectIndex(Idx))
         SpillSize += MFI.getObjectSize(Idx);
     }
 
     float SpillPct =
         static_cast<float>(SpillSize) / static_cast<float>(StackSize);
     float VarPct = 1.0f - SpillPct;
     int64_t VariableSize = StackSize - SpillSize;
-    dbgs() << formatv("{0}/{1} ({3:P}) spills, {2}/{1} ({4:P}) variables",
-                      SpillSize, StackSize, VariableSize, SpillPct, VarPct);
+    LLVM_DEBUG(dbgs() << formatv("{0}/{1} ({3:P}) spills, {2}/{1} ({4:P}) variables",
+                      SpillSize, StackSize, VariableSize, SpillPct, VarPct));
     if (UnsafeStackSize != 0) {
       float UnsafePct =
           static_cast<float>(UnsafeStackSize) / static_cast<float>(StackSize);
-      dbgs() << formatv(", {0}/{2} ({1:P}) unsafe stack", UnsafeStackSize,
-                        UnsafePct, StackSize);
+      LLVM_DEBUG(dbgs() << formatv(", {0}/{2} ({1:P}) unsafe stack", UnsafeStackSize,
+                        UnsafePct, StackSize));
     }
-    dbgs() << "\n";
+    LLVM_DEBUG(dbgs() << "\n");
   }
 
   ORE->emit([&]() {
     return MachineOptimizationRemarkAnalysis(DEBUG_TYPE, "StackSize",
                                              MF.getFunction().getSubprogram(),
                                              &MF.front())
            << ore::NV("NumStackBytes", StackSize) << " stack bytes in function";
   });