This is an archive of the discontinued LLVM Phabricator instance.

Differential D148996

[compiler-rt][test] Add `--large-address-aware` link flag for MinGW
ClosedPublic

Authored by alvinhochun on Apr 22 2023, 7:49 AM.

Details

Reviewers
vitalybuka
mstorsjo
Commits
rG1194e6f3fa59: [compiler-rt][test] Add `--large-address-aware` link flag for MinGW
Summary

The interception tests rely on the test binary being large address
aware. This has already been set for MSVC builds. Now we do the same for
MinGW.

This fixes the interception unit tests for i686-w64-windows-gnu target.

Diff Detail

Event Timeline

alvinhochun created this revision.Apr 22 2023, 7:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2023, 7:49 AM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
alvinhochun requested review of this revision.Apr 22 2023, 7:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2023, 7:49 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
mstorsjo accepted this revision.Apr 22 2023, 7:55 AM

LGTM, thanks for seeing this though!

This revision is now accepted and ready to land.Apr 22 2023, 7:55 AM
Harbormaster completed remote builds in B227459: Diff 516074.Apr 22 2023, 8:09 AM
Closed by commit rG1194e6f3fa59: [compiler-rt][test] Add `--large-address-aware` link flag for MinGW (authored by alvinhochun). · Explain WhyApr 25 2023, 4:26 AM
This revision was automatically updated to reflect the committed changes.
alvinhochun added a commit: rG1194e6f3fa59: [compiler-rt][test] Add `--large-address-aware` link flag for MinGW.

Revision Contents

PathSize
compiler-rt/
lib/
interception/
tests/
5 lines

Diff 516747

compiler-rt/lib/interception/tests/CMakeLists.txt

Show All 33 Lines
endif() endif()
if(MSVC) if(MSVC)
list(APPEND INTERCEPTION_TEST_CFLAGS_COMMON -gcodeview) list(APPEND INTERCEPTION_TEST_CFLAGS_COMMON -gcodeview)
list(APPEND INTERCEPTION_TEST_LINK_FLAGS_COMMON list(APPEND INTERCEPTION_TEST_LINK_FLAGS_COMMON
-Wl,-largeaddressaware -Wl,-largeaddressaware
-Wl,-nodefaultlib:libcmt,-defaultlib:msvcrt,-defaultlib:oldnames -Wl,-nodefaultlib:libcmt,-defaultlib:msvcrt,-defaultlib:oldnames
) )
endif() endif()
if(MINGW)
list(APPEND INTERCEPTION_TEST_LINK_FLAGS_COMMON
-Wl,--large-address-aware
)
endif()
list(APPEND INTERCEPTION_TEST_LINK_FLAGS_COMMON -g) list(APPEND INTERCEPTION_TEST_LINK_FLAGS_COMMON -g)
if(NOT MSVC) if(NOT MSVC)
list(APPEND INTERCEPTION_TEST_LINK_FLAGS_COMMON --driver-mode=g++) list(APPEND INTERCEPTION_TEST_LINK_FLAGS_COMMON --driver-mode=g++)
endif() endif()
if(ANDROID) if(ANDROID)
list(APPEND INTERCEPTION_TEST_LINK_FLAGS_COMMON -pie) list(APPEND INTERCEPTION_TEST_LINK_FLAGS_COMMON -pie)
▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines