This is an archive of the discontinued LLVM Phabricator instance.

Differential D148993

[CMake] Install FindLibEdit find module
ClosedPublic

Authored by ekilmer on Apr 22 2023, 7:33 AM.

Details

Reviewers
phosek
Dinistro
Commits
rG8167727b4a08: [CMake] Install FindLibEdit find module
Summary

This is a follow-up to D147153 and addresses CMake warnings about not
finding LibEdit find module when another project uses LLVM as a
dependency.

Fixes https://github.com/llvm/llvm-project/issues/62300

Diff Detail

Event Timeline

ekilmer created this revision.Apr 22 2023, 7:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2023, 7:33 AM
ekilmer requested review of this revision.Apr 22 2023, 7:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2023, 7:33 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B227456: Diff 516070.Apr 22 2023, 8:46 AM
definelicht added a subscriber: definelicht.May 2 2023, 3:52 AM
Dinistro added a subscriber: Dinistro.May 2 2023, 3:53 AM
Dinistro accepted this revision.May 2 2023, 7:00 AM

We observed the warning related to LibEdit and this patch seems to resolve it.

LGTM, but I'm no CMake expert, so someone else should take a look as well.

This revision is now accepted and ready to land.May 2 2023, 7:00 AM
ekilmer added a comment.May 4 2023, 5:52 AM

Thank you for testing and confirming this patch @Dinistro.

I don't know who else to tag to get a review. If/when someone else approves it, I would appreciate them helping me (if possible) to land this in main because I do not have commit access. Thank you!

Dinistro added a comment.May 4 2023, 6:22 AM

Given that there was no other interaction on this, I assume that it's fine to land this patch.
I'll take care of committing it for you.

Closed by commit rG8167727b4a08: [CMake] Install FindLibEdit find module (authored by ekilmer, committed by Dinistro). · Explain WhyMay 4 2023, 6:34 AM
This revision was automatically updated to reflect the committed changes.
Dinistro added a commit: rG8167727b4a08: [CMake] Install FindLibEdit find module.

Revision Contents

PathSize
cmake/
Modules/
llvm/
cmake/
modules/
cmake/
Modules/

Diff 519470

cmake/Modules/FindLibEdit.cmake

  • This file was moved to llvm/cmake/modules/FindLibEdit.cmake.

llvm/cmake/modules/FindLibEdit.cmake

  • This file was moved from cmake/Modules/FindLibEdit.cmake.
The contents of this file were not changed.