Check for a ‘buffer’ type instead of ‘buffer-live’.

[phst]

• Add customization group for MLIR.

[phst]

• Check for a ‘buffer’ type instead of ‘buffer-live’.

[phst]

Check for a ‘buffer’ type instead of ‘buffer-live’.

In Emacs 29, ‘buffer-live’ is no longer recognized as a type and generates a
compilation warning. Every function that requires a live buffer already checks
whether the buffer is live, so we don’t need to check ourselves.

[phst]

Thanks for the review! I think you also need to land it (I don't seem to have the necessary permissions).

clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.el

`(,clang-include-fixer-executable
     ,(clang-include-fixer--file-local-name buffer-file-name)))
 
 (defun clang-include-fixer--sentinel (stdin stdout stderr callback)
   "Return a process sentinel for clang-include-fixer processes.
 STDIN, STDOUT, and STDERR are buffers for the standard streams;
 only STDERR may be nil.  CALLBACK is called in the case of
 success; it is called with a single argument, STDOUT.  On
 failure, a buffer containing the error output is displayed."
-  (cl-check-type stdin buffer-live)
-  (cl-check-type stdout buffer-live)
-  (cl-check-type stderr (or null buffer-live))
+  (cl-check-type stdin buffer)
+  (cl-check-type stdout buffer)
+  (cl-check-type stderr (or null buffer))
   (cl-check-type callback function)
   (lambda (process event)
     (cl-check-type process process)
     (cl-check-type event string)
     (unwind-protect
         (if (string-equal event "finished\n")
             (progn
               (when stderr (kill-buffer stderr))
               (with-current-buffer stdin
                 (funcall callback stdout))
               (kill-buffer stdout))
           (when stderr (kill-buffer stdout))
           (message "clang-include-fixer failed")
           (with-current-buffer (or stderr stdout)
             (insert "\nProcess " (process-name process)
                     ?\s event))
           (display-buffer (or stderr stdout))))
     nil))
 
 (defun clang-include-fixer--replace-buffer (stdout)
   "Replace current buffer by content of STDOUT."
-  (cl-check-type stdout buffer-live)
+  (cl-check-type stdout buffer)
   (barf-if-buffer-read-only)
   (cond ((fboundp 'replace-buffer-contents) (replace-buffer-contents stdout))
         ((clang-include-fixer--insert-line stdout (current-buffer)))
         (t (erase-buffer) (insert-buffer-substring stdout)))
   (message "Fix applied")
   nil)
 
 (defun clang-include-fixer--insert-line (from to)
   "Insert a single missing line from the buffer FROM into TO.
 FROM and TO must be buffers.  If the contents of FROM and TO are
 equal, do nothing and return non-nil.  If FROM contains a single
 line missing from TO, insert that line into TO so that the buffer
 contents are equal and return non-nil.  Otherwise, do nothing and
 return nil.  Buffer restrictions are ignored."
-  (cl-check-type from buffer-live)
-  (cl-check-type to buffer-live)
+  (cl-check-type from buffer)
+  (cl-check-type to buffer)
   (with-current-buffer from
     (save-excursion
       (save-restriction
         (widen)
         (with-current-buffer to
           (save-excursion
             (save-restriction
               (widen)