This is an archive of the discontinued LLVM Phabricator instance.

Differential D148844

[libc] Add null-terminator to the thread name obtained from the syscall.
ClosedPublic

Authored by sivachandra on Apr 20 2023, 2:34 PM.

Download Raw Diff

Details

Reviewers

Commits

rG8972c0df42e0: [libc] Add null-terminator to the thread name obtained from the syscall.

Summary

This bug was caught by the aarch64 full build builder.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

sivachandra created this revision.Apr 20 2023, 2:34 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 20 2023, 2:34 PM

Herald added subscribers: libc-commits, ecnelises, tschuett, kristof.beyls. · View Herald Transcript

sivachandra requested review of this revision.Apr 20 2023, 2:34 PM

I am landing this to fix the builders. Feel free to review post submit as well.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2023, 2:35 PM

This revision was landed with ongoing or failed builds.

Closed by commit rG8972c0df42e0: [libc] Add null-terminator to the thread name obtained from the syscall. (authored by sivachandra). · Explain Why

This revision was automatically updated to reflect the committed changes.

sivachandra added a commit: rG8972c0df42e0: [libc] Add null-terminator to the thread name obtained from the syscall..

LGTM

Harbormaster completed remote builds in B226984: Diff 515489.Apr 20 2023, 2:51 PM

sivachandra mentioned this in D148293: [LIBC] Fix incorrect handling of `pthread_join(tid, nullptr)`.Apr 20 2023, 5:16 PM

sivachandra mentioned this in D148871: [libc] Another fix to add a null-terminator to the pthread name..Apr 20 2023, 8:31 PM

sivachandra mentioned this in rG596d87c4cce1: [libc] Another fix to add a null-terminator to the pthread name..Apr 20 2023, 8:34 PM

Revision Contents

Path

Size

libc/

src/

__support/

threads/

linux/

2 lines

Diff 515490

libc/src/__support/threads/linux/thread.cpp

	Show First 20 Lines • Show All 379 Lines • ▼ Show 20 Lines		#endif
	if (retval < 0)			if (retval < 0)
	return -retval;			return -retval;
	if (retval == NAME_SIZE_MAX)			if (retval == NAME_SIZE_MAX)
	return ERANGE;			return ERANGE;
	if (name_buffer[retval - 1] == '\n')			if (name_buffer[retval - 1] == '\n')
	name_buffer[retval - 1] = '\0';			name_buffer[retval - 1] = '\0';
	else			else
	name_buffer[retval] = '\0';			name_buffer[retval] = '\0';
	name << name_buffer;			name << name_buffer << cpp::StringStream::ENDS;
	return 0;			return 0;
	}			}

	void thread_exit(ThreadReturnValue retval, ThreadStyle style) {			void thread_exit(ThreadReturnValue retval, ThreadStyle style) {
	auto attrib = self.attrib;			auto attrib = self.attrib;

	// The very first thing we do is to call the thread's atexit callbacks.			// The very first thing we do is to call the thread's atexit callbacks.
	// These callbacks could be the ones registered by the language runtimes,			// These callbacks could be the ones registered by the language runtimes,
	Show All 26 Lines