This is an archive of the discontinued LLVM Phabricator instance.

Differential D148831

[libc++] Adds newer clang-tidy in the CI.
ClosedPublic

Authored by Mordante on Apr 20 2023, 12:07 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG019e784bb19b: [libc++] Adds newer clang-tidy in the CI.
Summary

In order to use clang-tidy for modules version 17 is required. Some of the
development fixes haven't been backported. This adds the new version to
the CI so it can be used in a follow-up patch.

Diff Detail

Event Timeline

Mordante created this revision.Apr 20 2023, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 12:07 PM
Herald added subscribers: carlosgalvezp, arichardson. · View Herald Transcript
Mordante requested review of this revision.Apr 20 2023, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 12:07 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante updated this revision to Diff 515750.Apr 21 2023, 8:27 AM

Trigger CI.

Harbormaster completed remote builds in B227186: Diff 515750.Apr 21 2023, 9:51 AM
ldionne accepted this revision.Apr 25 2023, 8:45 AM
ldionne added a subscriber: ldionne.

LGTM, but I think we should revert this patch to use the stable clang-tidy again once it supports the features you need for Modules. We had decided to use the stable clang-tidy to make sure CI issues were easily reproducible.

libcxx/utils/ci/Dockerfile
87–89
This revision is now accepted and ready to land.Apr 25 2023, 8:45 AM
Mordante marked an inline comment as done.Apr 27 2023, 8:21 AM
Mordante added inline comments.
libcxx/utils/ci/Dockerfile
87–89

I uses slightly different wording and referred to this review.

This revision was landed with ongoing or failed builds.Apr 27 2023, 8:24 AM
Closed by commit rG019e784bb19b: [libc++] Adds newer clang-tidy in the CI. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.
Mordante added a commit: rG019e784bb19b: [libc++] Adds newer clang-tidy in the CI..

Revision Contents

PathSize
libcxx/
utils/
ci/
10 lines

Diff 517574

libcxx/utils/ci/Dockerfile

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 LinesRUN apt-get update && apt-get install -y clang-tools-$(($LLVM_HEAD_VERSION - 3)) \
clang-tools-$(($LLVM_HEAD_VERSION - 2)) \ clang-tools-$(($LLVM_HEAD_VERSION - 2)) \
clang-tools-$(($LLVM_HEAD_VERSION - 1)) \ clang-tools-$(($LLVM_HEAD_VERSION - 1)) \
clang-tools-$LLVM_HEAD_VERSION clang-tools-$LLVM_HEAD_VERSION
# Install clang-format; always use the lastest stable branch. # Install clang-format; always use the lastest stable branch.
RUN apt-get update && apt-get install -y clang-format-$(($LLVM_HEAD_VERSION - 2)) clang-format-$(($LLVM_HEAD_VERSION - 1)) RUN apt-get update && apt-get install -y clang-format-$(($LLVM_HEAD_VERSION - 2)) clang-format-$(($LLVM_HEAD_VERSION - 1))
# Install clang-tidy # Install clang-tidy
RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 2)) clang-tidy-$((LLVM_HEAD_VERSION - 1)) # TODO LLVM 17 revert D148831 to only install $(($LLVM_HEAD_VERSION - 1)) and $LLVM_HEAD_VERSION
# The usage of the ToT version is needed due to module issues with Clang 16
RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 2)) clang-tidy-$(($LLVM_HEAD_VERSION - 1)) clang-tidy-$LLVM_HEAD_VERSION
ldionneUnsubmitted
Done
ReplyInline Actions
# Install clang-tidy
- # TODO LLVM 18 only install $(($LLVM_HEAD_VERSION - 1)) and $LLVM_HEAD_VERSION
+ # TODO(LLVM 17) Only install $(($LLVM_HEAD_VERSION - 1)) and $(($LLVM_HEAD_VERSION - 2)) again once the latest stable clang-tidy is clang-tidy-17
RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 2)) clang-tidy-$(($LLVM_HEAD_VERSION - 1)) clang-tidy-$LLVM_HEAD_VERSION
ldionne:
MordanteAuthorUnsubmitted
Done
ReplyInline Actions

I uses slightly different wording and referred to this review.

Mordante: I uses slightly different wording and referred to this review.
# Install llvm-dev and libclang-dev to compile custom clang-tidy checks # Install llvm-dev and libclang-dev to compile custom clang-tidy checks
RUN apt-get update && apt-get install -y llvm-$(($LLVM_HEAD_VERSION - 1))-dev llvm-$(($LLVM_HEAD_VERSION - 2))-dev \ # TODO LLVM 17 revert D148831 to only install $(($LLVM_HEAD_VERSION - 1)) and $LLVM_HEAD_VERSION
libclang-$(($LLVM_HEAD_VERSION - 1))-dev libclang-$(($LLVM_HEAD_VERSION - 2))-dev # The usage of the ToT version is needed due to module issues with Clang 16
RUN apt-get update && apt-get install -y llvm-$(($LLVM_HEAD_VERSION - 2))-dev llvm-$(($LLVM_HEAD_VERSION - 1))-dev llvm-$LLVM_HEAD_VERSION-dev \
libclang-$(($LLVM_HEAD_VERSION - 2))-dev libclang-$(($LLVM_HEAD_VERSION - 1))-dev libclang-$LLVM_HEAD_VERSION-dev
# Install the most recent GCC, like clang install the previous version as a transition. # Install the most recent GCC, like clang install the previous version as a transition.
ENV GCC_LATEST_VERSION=12 ENV GCC_LATEST_VERSION=12
RUN apt-get update && apt install -y gcc-$((GCC_LATEST_VERSION - 1)) g++-$((GCC_LATEST_VERSION - 1)) RUN apt-get update && apt install -y gcc-$((GCC_LATEST_VERSION - 1)) g++-$((GCC_LATEST_VERSION - 1))
RUN apt-get update && apt install -y gcc-$GCC_LATEST_VERSION g++-$GCC_LATEST_VERSION RUN apt-get update && apt install -y gcc-$GCC_LATEST_VERSION g++-$GCC_LATEST_VERSION
# Remove all, no longer needed, apt data # Remove all, no longer needed, apt data
RUN rm -rf /var/lib/apt/lists/* RUN rm -rf /var/lib/apt/lists/*
Show All 28 Lines