This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Adds newer clang-tidy in the CI.
ClosedPublic

Authored by Mordante on Apr 20 2023, 12:07 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG019e784bb19b: [libc++] Adds newer clang-tidy in the CI.
Summary

In order to use clang-tidy for modules version 17 is required. Some of the
development fixes haven't been backported. This adds the new version to
the CI so it can be used in a follow-up patch.

Diff Detail

Event Timeline

Mordante created this revision.Apr 20 2023, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 12:07 PM
Mordante requested review of this revision.Apr 20 2023, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 12:07 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante updated this revision to Diff 515750.Apr 21 2023, 8:27 AM

Trigger CI.

ldionne accepted this revision.Apr 25 2023, 8:45 AM
ldionne added a subscriber: ldionne.

LGTM, but I think we should revert this patch to use the stable clang-tidy again once it supports the features you need for Modules. We had decided to use the stable clang-tidy to make sure CI issues were easily reproducible.

libcxx/utils/ci/Dockerfile
87–89
This revision is now accepted and ready to land.Apr 25 2023, 8:45 AM
Mordante marked an inline comment as done.Apr 27 2023, 8:21 AM
Mordante added inline comments.
libcxx/utils/ci/Dockerfile
87–89

I uses slightly different wording and referred to this review.

This revision was landed with ongoing or failed builds.Apr 27 2023, 8:24 AM
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.