This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Switch back to -fPIC for Fuchsia Toolchain
ClosedPublic

Authored by mysterymath on Apr 17 2023, 3:57 PM.

Details

Summary

This reverts commit 1fab236e6e4575d5af4f4722216df4dd6a872795.

Shipping LLDB means distributing libLLDB.so, which will need to be built
with PIC. Disabling PIC also removes the libLTO target, which is a hard
dependency of the LLDB test suite.

Diff Detail

Event Timeline

mysterymath created this revision.Apr 17 2023, 3:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 3:57 PM
Herald added a subscriber: ekilmer. · View Herald Transcript
mysterymath requested review of this revision.Apr 17 2023, 3:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 3:57 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
abrachet accepted this revision.Apr 19 2023, 11:47 AM
This revision is now accepted and ready to land.Apr 19 2023, 11:47 AM
This revision was automatically updated to reflect the committed changes.